MGMT-15349: Don't attempt to contact spoke while unbinding a day2 host

[carbonin]

If an agent is unbound while it is installing the transition will fail, but the agent spec will still have no cluster deployment reference. The agent controller should not attempt to contact the spoke cluster in this case.

Previously unbinding a day-2 host that was installing could cause a panic. This patch guards against that situation.

Additionally this should be covered by the agent validating webhook which prevents agents from being unbound while they are installing, but we still shouldn't crash if this does happen to slip through somehow.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-15349

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see [CONTRIBUTING] guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@carbonin: This pull request references MGMT-15349 which is a valid jira issue.

In response to this:

If an agent is unbound while it is installing the transition will fail, but the agent spec will still have no cluster deployment reference. The agent controller should not attempt to contact the spoke cluster in this case.

Previously unbinding a day-2 host that was installing could cause a panic. This patch guards against that situation.

Additionally this should be covered by the agent validating webhook which prevents agents from being unbound while they are installing, but we still shouldn't crash if this does happen to slip through somehow.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-15349

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see [CONTRIBUTING] guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5383 (5968d86) into master (6a583ef) will increase coverage by 0.23%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5383      +/-   ##
==========================================
+ Coverage   67.67%   67.91%   +0.23%     
==========================================
  Files         226      226              
  Lines       33349    33582     +233     
==========================================
+ Hits        22570    22806     +236     
+ Misses       8745     8737       -8     
- Partials     2034     2039       +5     

Files Changed	Coverage Δ
...nternal/controller/controllers/agent_controller.go	77.52% <100.00%> (+0.02%)	⬆️

... and 6 files with indirect coverage changes

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [carbonin,filanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@carbonin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-ai-operator-ztp-capi	5968d86	link	false	/test edge-e2e-ai-operator-ztp-capi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[carbonin]

/cherry-pick release-ocm-2.8

[openshift-cherrypick-robot]

@carbonin: new pull request created: #5388

In response to this:

/cherry-pick release-ocm-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.