Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.8] MGMT-15381: Don't attempt to contact spoke while unbinding a day2 host #5388

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5383

/assign carbonin

If an agent is unbound while it is installing the transition will fail,
but the agent spec will still have no cluster deployment reference.
The agent controller should not attempt to contact the spoke cluster in
this case.

Previously unbinding a day-2 host that was installing could cause a
panic. This patch guards against that situation.

https://issues.redhat.com/browse/MGMT-15349
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2023

@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-15349](https://issues.redhat.com//browse/MGMT-15349) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #5383

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2023

@openshift-ci-robot: This pull request references MGMT-15349 which is a valid jira issue.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-15349](https://issues.redhat.com//browse/MGMT-15349) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #5383

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2023
@carbonin carbonin changed the title [release-ocm-2.8] MGMT-15349: Don't attempt to contact spoke while unbinding a day2 host [release-ocm-2.8] MGMT-15381: Don't attempt to contact spoke while unbinding a day2 host Jul 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2023

@openshift-cherrypick-robot: This pull request references MGMT-15381 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #5383

/assign carbonin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carbonin
Copy link
Member

cc @filanov

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2023
@openshift-ci openshift-ci bot requested review from eliorerz and filanov July 26, 2023 17:37
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #5388 (4a0e69d) into release-ocm-2.8 (dd4be30) will increase coverage by 0.00%.
Report is 1 commits behind head on release-ocm-2.8.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-ocm-2.8    #5388   +/-   ##
================================================
  Coverage            67.50%   67.51%           
================================================
  Files                  218      218           
  Lines                32720    32721    +1     
================================================
+ Hits                 22087    22090    +3     
+ Misses                8641     8640    -1     
+ Partials              1992     1991    -1     
Files Changed Coverage Δ
...nternal/controller/controllers/agent_controller.go 77.52% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@filanov
Copy link
Contributor

filanov commented Jul 31, 2023

/override ci/prow/e2e-ai-operator-ztp-capi
job is flaky

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

@filanov: Overrode contexts on behalf of filanov: ci/prow/e2e-ai-operator-ztp-capi

In response to this:

/override ci/prow/e2e-ai-operator-ztp-capi
job is flaky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b6735c2 into openshift:release-ocm-2.8 Jul 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants