New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-ocm-2.8] MGMT-15381: Don't attempt to contact spoke while unbinding a day2 host #5388
Conversation
If an agent is unbound while it is installing the transition will fail, but the agent spec will still have no cluster deployment reference. The agent controller should not attempt to contact the spoke cluster in this case. Previously unbinding a day-2 host that was installing could cause a panic. This patch guards against that situation. https://issues.redhat.com/browse/MGMT-15349
@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-15349](https://issues.redhat.com//browse/MGMT-15349) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: This pull request references MGMT-15349 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references MGMT-15381 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @filanov |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.8 #5388 +/- ##
================================================
Coverage 67.50% 67.51%
================================================
Files 218 218
Lines 32720 32721 +1
================================================
+ Hits 22087 22090 +3
+ Misses 8641 8640 -1
+ Partials 1992 1991 -1
|
/override ci/prow/e2e-ai-operator-ztp-capi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@filanov: Overrode contexts on behalf of filanov: ci/prow/e2e-ai-operator-ztp-capi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
b6735c2
into
openshift:release-ocm-2.8
This is an automated cherry-pick of #5383
/assign carbonin