NO-ISSUE: Fix email domain for event uploader

[CrystalChun]

Email domain was set to Unknown by default for
clusters. This modifies the check for that and
ensures it's set to an actual email domain for
on-prem event uploading.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @rccrdpccl

[openshift-ci-robot]

@CrystalChun: This pull request explicitly references no jira issue.

In response to this:

Email domain was set to Unknown by default for
clusters. This modifies the check for that and
ensures it's set to an actual email domain for
on-prem event uploading.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @rccrdpccl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CrystalChun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #5511 (d29af0f) into master (81a2d67) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5511      +/-   ##
==========================================
- Coverage   67.65%   67.62%   -0.04%     
==========================================
  Files         232      232              
  Lines       34092    34089       -3     
==========================================
- Hits        23066    23053      -13     
- Misses       8967     8973       +6     
- Partials     2059     2063       +4     

Files	Coverage Δ
internal/uploader/auth_utils.go	73.52% <100.00%> (+3.25%)	⬆️
internal/uploader/events_uploader.go	67.12% <100.00%> (ø)

... and 3 files with indirect coverage changes

[CrystalChun]

/retest

[openshift-ci]

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rccrdpccl]

/lgtm

[rccrdpccl]

/cherry-pick cloud_hotfix_releases

[openshift-cherrypick-robot]

@rccrdpccl: new pull request created: #5516

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CrystalChun]

/cherry-pick release-ocm-2.9

[openshift-cherrypick-robot]

@CrystalChun: new pull request created: #5526

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CrystalChun]

/cherry-pick release-ocm-2.8

[openshift-cherrypick-robot]

@CrystalChun: new pull request created: #5532

In response to this:

/cherry-pick release-ocm-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.