-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-ocm-2.9] NO-ISSUE: Fix email domain for event uploader #5526
[release-ocm-2.9] NO-ISSUE: Fix email domain for event uploader #5526
Conversation
Email domain was set to Unknown by default for clusters. This modifies the check for that and ensures it's set to an actual email domain for on-prem event uploading.
@openshift-cherrypick-robot: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.9 #5526 +/- ##
===================================================
+ Coverage 67.64% 67.65% +0.01%
===================================================
Files 232 232
Lines 33988 33978 -10
===================================================
- Hits 22991 22989 -2
+ Misses 8946 8942 -4
+ Partials 2051 2047 -4
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #5511
/assign CrystalChun