Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.9] NO-ISSUE: Fix email domain for event uploader #5526

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5511

/assign CrystalChun

Email domain was set to Unknown by default for
clusters. This modifies the check for that and
ensures it's set to an actual email domain for
on-prem event uploading.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request explicitly references no jira issue.

In response to this:

This is an automated cherry-pick of #5511

/assign CrystalChun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #5526 (bcd8ecf) into release-ocm-2.9 (a3cd274) will increase coverage by 0.01%.
Report is 1 commits behind head on release-ocm-2.9.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.9    #5526      +/-   ##
===================================================
+ Coverage            67.64%   67.65%   +0.01%     
===================================================
  Files                  232      232              
  Lines                33988    33978      -10     
===================================================
- Hits                 22991    22989       -2     
+ Misses                8946     8942       -4     
+ Partials              2051     2047       -4     
Files Coverage Δ
...nal/controller/controllers/bmh_agent_controller.go 74.91% <100.00%> (+0.14%) ⬆️
internal/uploader/auth_utils.go 73.52% <100.00%> (+3.25%) ⬆️
internal/uploader/events_uploader.go 67.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 433d225 into openshift:release-ocm-2.9 Oct 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants