New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-15950: Fix DNS wilcard domain validation #5544
Conversation
@ori-amizur: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
DNS wildcard domain starts with validateNoWildcardDNS. The domain may have an optional trailing dot. Currently the assumption is that the trailing dot is mandatory for the domain name.
c923f6a
to
8ee9566
Compare
@ori-amizur: This pull request references MGMT-15950 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
/lgtm |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5544 +/- ##
==========================================
+ Coverage 67.66% 67.69% +0.02%
==========================================
Files 232 232
Lines 34149 34149
==========================================
+ Hits 23108 23116 +8
+ Misses 8980 8974 -6
+ Partials 2061 2059 -2
|
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
DNS wildcard domain starts with validateNoWildcardDNS. The domain may have an optional trailing dot. Currently the assumption is that the trailing dot is mandatory for the domain name.
DNS wildcard domain starts with validateNoWildcardDNS. The domain may have an optional trailing dot. Currently the assumption is that the trailing dot is mandatory for the domain name.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @tsorya