MGMT-16494: Move ip hint file creation to ignition in order to change it in IBI process #5861
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
tsorya
force-pushed
the
igal/node_ip_hint
branch
from
5dce796
to
35ffa1c
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
tsorya
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@tsorya: This pull request references MGMT-16494 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tsorya
force-pushed
the
igal/node_ip_hint
branch
from
35ffa1c
to
42ce0a8
Compare
| @@ -1510,7 +1511,7 @@ func (g *installerGenerator) modifyPointerIgnitionMCP(poolName string, ignitionS | |||
| return "", errors.Errorf("machine config pool %s was not found", poolName) | |||
| } | |||
|
|
|||
| func (g *installerGenerator) writeSingleHostFile(host *models.Host, baseFile string, workDir, serviceBaseURL, bootReporter string, authType auth.AuthType) error { | |||
| func (g *installerGenerator) writeSingleHostFile(host *models.Host, baseFile string, workDir string) error { | |||
There was a problem hiding this comment.
Any clue why serviceBaseURL, bootReporter and authType are in the signature???
There was a problem hiding this comment.
Were not used so i removed them
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5861 +/- ##
==========================================
+ Coverage 68.05% 69.56% +1.51%
==========================================
Files 235 235
Lines 34574 36156 +1582
==========================================
+ Hits 23528 25153 +1625
+ Misses 8984 8894 -90
- Partials 2062 2109 +47
|
tsorya
force-pushed
the
igal/node_ip_hint
branch
from
42ce0a8
to
9cd73e3
Compare
tsorya
force-pushed
the
igal/node_ip_hint
branch
2 times, most recently
from
f1c155b
to
d560ecf
Compare
… it in IBI process
tsorya
force-pushed
the
igal/node_ip_hint
branch
from
d560ecf
to
1094ee4
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
/unhold |
|
also abi |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/test ? |
|
@tsorya: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-metal-assisted-mce-sno |
|
/retest |
|
/override /test e2e-agent-compact-ipv4 |
|
/override e2e-agent-compact-ipv4 |
|
@tsorya: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@tsorya: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ci/prow/e2e-agent-compact-ipv4 |
|
@rccrdpccl: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-agent-compact-ipv4 |
|
/override ci/prow/e2e-agent-compact-ipv4 |
|
@tsorya: Overrode contexts on behalf of tsorya: ci/prow/e2e-agent-compact-ipv4 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-agent-compact-ipv4 |
|
@tsorya: Overrode contexts on behalf of tsorya: ci/prow/e2e-agent-compact-ipv4 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tsorya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-ocm-2.9 |
|
@gamli75: new pull request created: #5882 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-ocm-2.8 |
|
@gamli75: #5861 failed to apply on top of branch "release-ocm-2.8": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.15 |
|
@tsorya: new pull request created: #5926 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist