Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.9] MGMT-16494: Move ip hint file creation to ignition in order to change it in IBI process #5882

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5861

/assign gamli75

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2024

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-16494

In response to this:

This is an automated cherry-pick of #5861

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (aa1d952) 67.63% compared to head (2b7e9d9) 67.61%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.9    #5882      +/-   ##
===================================================
- Coverage            67.63%   67.61%   -0.02%     
===================================================
  Files                  232      232              
  Lines                34076    34051      -25     
===================================================
- Hits                 23048    23025      -23     
+ Misses                8979     8978       -1     
+ Partials              2049     2048       -1     
Files Coverage Δ
internal/cluster/cluster.go 66.85% <ø> (+0.12%) ⬆️
internal/network/manifests_generator.go 72.83% <ø> (-2.92%) ⬇️
internal/ignition/ignition.go 60.41% <76.92%> (+0.03%) ⬆️

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2024
Copy link

openshift-ci bot commented Jan 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2024
Copy link

openshift-ci bot commented Jan 14, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@filanov filanov added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b089c14 into openshift:release-ocm-2.9 Jan 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants