-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-16501: Add request headers to api_vip_connectivity check request #5870
Conversation
@CrystalChun: This pull request references MGMT-16501 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
@CrystalChun: This pull request references MGMT-16501 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@CrystalChun: This pull request references MGMT-16501 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5870 +/- ##
==========================================
+ Coverage 68.03% 68.10% +0.06%
==========================================
Files 235 235
Lines 34574 34640 +66
==========================================
+ Hits 23523 23592 +69
+ Misses 8988 8985 -3
Partials 2063 2063
|
08cf018
to
b693baf
Compare
b693baf
to
1839a3a
Compare
https://issues.redhat.com/browse/MGMT-16501 API change to include additional request headers when making a call to the ignition endpoint. Allows for more flexibility to pass headers to different ignition servers.
1839a3a
to
c28b45a
Compare
/lgtm |
@CrystalChun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202401180211.p0.ga75c684.assembly.stream for distgit ose-agent-installer-api-server. |
MGMT-16501
API change to include additional request headers when making a call to the ignition endpoint. Allows for more flexibility to pass headers to different ignition servers.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Pre-steps:
Backwards compatibility test:
Using new header test:
Checklist
docs
, README, etc)Reviewers Checklist
/cc @avishayt