Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16995 fixing lvm requirement message #6009

Merged
merged 1 commit into from Feb 22, 2024
Merged

MGMT-16995 fixing lvm requirement message #6009

merged 1 commit into from Feb 22, 2024

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Feb 21, 2024

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot
Copy link

@eifrach: This pull request explicitly references no jira issue.

In response to this:

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 21, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@eifrach
Copy link
Contributor Author

eifrach commented Feb 21, 2024 •
edited by openshift-ci bot

/retitle "MGMT-16995] fixing lvm requirement message"

@openshift-ci openshift-ci bot changed the title NO-ISSUE: fixing lvm requirement message "MGMT-16995] fixing lvm requirement message" Feb 21, 2024
@eifrach eifrach changed the title "MGMT-16995] fixing lvm requirement message" "MGMT-16995 fixing lvm requirement message" Feb 21, 2024
@eifrach eifrach changed the title "MGMT-16995 fixing lvm requirement message" MGMT-16995 fixing lvm requirement message Feb 21, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (d9e7d73) to head (c322ac2).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6009      +/-   ##
==========================================
- Coverage   68.30%   68.30%   -0.01%     
==========================================
  Files         236      237       +1     
  Lines       35102    35115      +13     
==========================================
+ Hits        23978    23984       +6     
- Misses       9047     9057      +10     
+ Partials     2077     2074       -3
Files Coverage Δ
internal/operators/lvm/lvm_operator.go 80.61% <100.00%> (ø)

... and 3 files with indirect coverage changes

rccrdpccl
rccrdpccl reviewed Feb 21, 2024
View reviewed changes
internal/operators/lvm/lvm_operator.go
@@ -173,9 +173,9 @@ func (o *operator) GetPreflightRequirements(context context.Context, cluster *co
Requirements: &models.HostTypeHardwareRequirementsWrapper{
Master: &models.HostTypeHardwareRequirements{
Qualitative: []string{
"At least 1 non-boot disk on one or more host",
fmt.Sprintf("%d GiB of additional RAM", memoryRequirements),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe should specify MB in the name of the variable? i.e. memoryRequirementsMB or something?

@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 59f9969 and 2 for PR HEAD c322ac2 in total

@eifrach
Copy link
Contributor Author

eifrach commented Feb 22, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 22, 2024

@eifrach: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 c322ac2 link false /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 45ed7e9 and 1 for PR HEAD c322ac2 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 5cc50f6 into openshift:master Feb 22, 2024
16 of 17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202402222239.p0.g5cc50f6.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rccrdpccl rccrdpccl rccrdpccl left review comments

@carbonin carbonin Awaiting requested review from carbonin

@romfreiman romfreiman Awaiting requested review from romfreiman

Assignees

@rccrdpccl rccrdpccl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eifrach @openshift-ci-robot @rccrdpccl @openshift-bot