Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16995 fixing lvm requirement message #6009

Merged
merged 1 commit into from
Feb 22, 2024
Merged

MGMT-16995 fixing lvm requirement message #6009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/operators/lvm/lvm_operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,9 @@ func (o *operator) GetPreflightRequirements(context context.Context, cluster *co
Requirements: &models.HostTypeHardwareRequirementsWrapper{
Master: &models.HostTypeHardwareRequirements{
Qualitative: []string{
"At least 1 non-boot disk on one or more host",
fmt.Sprintf("%d GiB of additional RAM", memoryRequirements),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe should specify MB in the name of the variable? i.e. memoryRequirementsMB or something?

fmt.Sprintf("%d additional CPUs for each non-boot disk", memoryRequirements),
"At least 1 non-boot disk per host",
fmt.Sprintf("%d MiB of additional RAM", memoryRequirements),
fmt.Sprintf("%d additional CPUs for each non-boot disk", o.Config.LvmCPUPerHost),
},
Quantitative: &models.ClusterHostRequirementsDetails{
CPUCores: o.Config.LvmCPUPerHost,
Expand Down