Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE Pin cryptography Python dependency to 3.3.2 #497

Merged
merged 1 commit into from
Feb 7, 2021
Merged

NO-ISSUE Pin cryptography Python dependency to 3.3.2 #497

merged 1 commit into from
Feb 7, 2021

Conversation

empovit
Copy link
Contributor

@empovit empovit commented Feb 7, 2021 •
edited
Loading

Pin the cryptography dependency to the latest version before 3.4 to fix
ModuleNotFoundError: No module named 'setuptools_rust'

@empovit
NO-ISSUE Pin cryptography Python dependency
4d8cb91 
Pin cryptography to the latest version before 3.4 to fix
ModuleNotFoundError: No module named 'setuptools_rust'
@empovit
Copy link
Contributor Author

empovit commented Feb 7, 2021

/cc @osherdp @omertuc @tsorya

@empovit empovit changed the title NO-ISSUE Pin cryptography Python dependency NO-ISSUE Pin cryptography Python dependency to 3.3.2 Feb 7, 2021
@empovit
Copy link
Contributor Author

empovit commented Feb 7, 2021 •
edited
Loading

See pyca/cryptography#5753. However, upgrading pip as suggested causes

ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

Downgrading cryptography until a better solution is found.

YuviGold
YuviGold approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@YuviGold YuviGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: empovit, YuviGold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2021
@YuviGold
Copy link
Contributor

YuviGold commented Feb 7, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit a71ad12 into openshift:master Feb 7, 2021
@empovit empovit mentioned this pull request Feb 8, 2021
Merged
@empovit empovit deleted the fix-setuptools_rust branch February 8, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuviGold YuviGold YuviGold approved these changes

@romfreiman romfreiman Awaiting requested review from romfreiman

@ronniel1 ronniel1 Awaiting requested review from ronniel1

@omertuc omertuc Awaiting requested review from omertuc

@osherdp osherdp Awaiting requested review from osherdp

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@YuviGold YuviGold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@empovit @openshift-ci-robot @YuviGold @openshift-merge-robot