Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CR name #29

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Apr 8, 2020

Only name: cluster is allowed. Using enum, because it has better error message than pattern:

With enum:

The Driver "clusterX" is invalid: metadata.name: Unsupported value: "clusterX": supported values: "cluster"

With pattern: "^cluster$":

The Driver "clusterX" is invalid: metadata.name: Invalid value: "": metadata.name in body should match '^cluster$'

Fixes: #21

Only "name: cluster" is allowed.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@gnufied
Copy link
Member

gnufied commented Apr 8, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single CR through API validation of metadata.name
4 participants