MULTIARCH-4304: Add validation for the name of the PodPlacementConfig…

[AnnaZivkovic]

… so there can only be one cluster

Unfortunately, make manifests overrides manually adding validation (example here) in multiarch.openshift.io_podplacementconfigs.yaml.

The only issue with using +kubebuilder:validation:XValidation:rule is the error message is not as nicely formatted as shown

[openshift-ci-robot]

@AnnaZivkovic: This pull request references MULTIARCH-4304 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

… so there can only be one cluster

Unfortunately, make manifests overrides manually adding validation (example here) in multiarch.openshift.io_podplacementconfigs.yaml.

The only issue with using +kubebuilder:validation:XValidation:rule is the error message is not as nicely formatted as shown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[aleskandro]

The error doesn't look so bad to me and the solution is quick enough to cover the problem for now.

The alternative is to hack the Makefile target so that the CRD yaml is patched after all the other steps execute: we're needing it in https://github.com/openshift/multiarch-tuning-operator/pull/70/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R291 (as per suggestions in some operator-framework threads internally), but I like that even less.

What's the field the API is considering to be <nil>? Any way we can change it?

[aleskandro]

@AnnaZivkovic, remember that we also have to remove any previous code that was checking the name in the pod placement config controller.

Also, let's check the integration test cases, patch any that were already verifying the previous work, or add at least one integration/unit test that verifies CR with a wrong name cannot be created

[AnnaZivkovic]

@aleskandro are you talking about removing the logic here and the stuff below it?

[aleskandro]

From line 100 in particular. But yes, we could even delete that if statement that you linked as we can assume the name of the object will always be the correct one

[AnnaZivkovic]

/retest-required

[AnnaZivkovic]

/retest-required

[AnnaZivkovic]

/retest-required

[AnnaZivkovic]

/retest

[AnnaZivkovic]

/test vendor

[aleskandro]

Hey @AnnaZivkovic thanks!

Leaving some comments. In general, it looks good to me. I wonder if we can simplify the kustomize to buffer process by using resMap (see suggestions).

[openshift-ci]

@AnnaZivkovic: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[aleskandro]

/lgtm
/approve

Thanks @AnnaZivkovic

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aleskandro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment