Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29070: Add feature annotations to CSV #127

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Feb 9, 2024

Add all required feature annotations to the operator. See the bug for our internal test report.

I am skipping the optional ones (cnv, cnf), I think false is implied there.

@openshift/storage

Add all required feature annotations to the operator.
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@jsafrane jsafrane changed the title Add feature annotations to CSV OCPBUGS-29070: Add feature annotations to CSV Feb 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2024
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-29070, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add all required feature annotations to the operator. See the bug for our internal test report.

I am skipping the optional ones (cnv, cnf), I think false is implied there.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 9, 2024
@dobsonj
Copy link
Member

dobsonj commented Feb 12, 2024

/retest-required
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 35fa995 into openshift:master Feb 12, 2024
9 checks passed
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-29070: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29070 has been moved to the MODIFIED state.

In response to this:

Add all required feature annotations to the operator. See the bug for our internal test report.

I am skipping the optional ones (cnv, cnf), I think false is implied there.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.16.0-202402130109.p0.g35fa995.assembly.stream.el9 for distgit ose-aws-efs-csi-driver-operator.
All builds following this will include this PR.

@jsafrane
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@jsafrane: #127 failed to apply on top of branch "release-4.15":

Applying: Add feature annotations to CSV
Using index info to reconstruct a base tree...
M	config/manifests/stable/aws-efs-csi-driver-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/manifests/stable/aws-efs-csi-driver-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in config/manifests/stable/aws-efs-csi-driver-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add feature annotations to CSV
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants