Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30113: 4.13: Add feature annotations to CSV #130

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 1, 2024

Add all required feature annotations to the operator.
This is a manual cherry-pick of #127 to 4.13.
In 4.13, we do not support "tokenized authentication with AWS APIs via AWS Secure Token Service (STS) by using the Cloud Credential Operator (CCO)", that was added as 4.14 feature https://issues.redhat.com/browse/STOR-1347

@openshift/storage

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2024

/jira cherrypick OCPBUGS-30110

Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-30110 has been cloned as Jira Issue OCPBUGS-30113. Will retitle bug to link to clone.
/retitle OCPBUGS-30113: 4.13: Add feature annotations to CSV

In response to this:

/jira cherrypick OCPBUGS-30110

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title 4.13: Add feature annotations to CSV OCPBUGS-30113: 4.13: Add feature annotations to CSV Mar 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 1, 2024
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-30113, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30110 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add all required feature annotations to the operator.
This is a manual cherry-pick of #127 to 4.13.
In 4.13, we do not support "tokenzied authentication with AWS APIs via AWS Secure Token Service (STS) by using the Cloud Credential Operator (CCO)", that was added ass 4.14 feature https://issues.redhat.com/browse/STOR-1347

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Add all required feature annotations to the operator.
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 1, 2024
@chao007
Copy link

chao007 commented Mar 1, 2024

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 1, 2024
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Mar 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 7, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 7, 2024
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-30113, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30110 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30110 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @ropatil010

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from ropatil010 March 7, 2024 08:55
@openshift-merge-bot openshift-merge-bot bot merged commit 66ed06c into openshift:release-4.13 Mar 7, 2024
7 checks passed
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-30113: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30113 has been moved to the MODIFIED state.

In response to this:

Add all required feature annotations to the operator.
This is a manual cherry-pick of #127 to 4.13.
In 4.13, we do not support "tokenized authentication with AWS APIs via AWS Secure Token Service (STS) by using the Cloud Credential Operator (CCO)", that was added as 4.14 feature https://issues.redhat.com/browse/STOR-1347

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.13.0-202403070943.p0.g66ed06c.assembly.stream.el8 for distgit ose-aws-efs-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants