Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statics don't get deleted #15

Closed
2uasimojo opened this issue Jun 16, 2020 · 0 comments · Fixed by #21
Closed

Statics don't get deleted #15

2uasimojo opened this issue Jun 16, 2020 · 0 comments · Fixed by #21

Comments

@2uasimojo
Copy link
Member

2uasimojo commented Jun 16, 2020 •
edited
Loading

When the operator is installed, the statics controller creates the following resources:

  • Namespace scoped:
    • DaemonSet (running the CSI driver)
    • ServiceAccount
  • Cluster scoped:
    • SecurityContextConstraints
    • CSIDriver
    • StorageClass

Currently (master commit 7eb38e7) there is no cleanup of these resources when the operator is unintsalled. (There is a delete_statics.sh script but it needs to be run by an admin.)

Jira: OSD-4083
@2uasimojo 2uasimojo mentioned this issue Jul 1, 2020
Closed
2uasimojo added a commit to 2uasimojo/aws-efs-operator that referenced this issue Jul 1, 2020
@2uasimojo
Make statics owned by the CustomResourceDefinition
67911d3 
...so they get deleted automatically when the operator is uninstalled.

This still doesn't clean up the SCC, which may be an upstream bug.  Trying to figure that out in [slack](https://coreos.slack.com/archives/CB48XQ4KZ/p1593546841423000)

Jira: [OSD-4083](https://issues.redhat.com/browse/OSD-4083)
Fixes: openshift#15
@2uasimojo 2uasimojo mentioned this issue Jul 1, 2020
Merged
2uasimojo added a commit to 2uasimojo/aws-efs-operator that referenced this issue Jul 1, 2020
@2uasimojo
Make statics owned by the CustomResourceDefinition
935889c 
...so they get deleted automatically when the operator is uninstalled.

This still doesn't clean up the SCC, which may be an upstream bug.  Trying to figure that out in [slack](https://coreos.slack.com/archives/CB48XQ4KZ/p1593546841423000)

Jira: [OSD-4083](https://issues.redhat.com/browse/OSD-4083)
Fixes: openshift#15
2uasimojo added a commit to 2uasimojo/aws-efs-operator that referenced this issue Jul 1, 2020
@2uasimojo
Make statics owned by the CustomResourceDefinition
9de988e 
...so they get deleted automatically when the operator is uninstalled.

This still doesn't clean up the SCC, which may be an upstream bug.  Trying to figure that out in [slack](https://coreos.slack.com/archives/CB48XQ4KZ/p1593546841423000)

Jira: [OSD-4083](https://issues.redhat.com/browse/OSD-4083)
Fixes: openshift#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make statics owned by the CustomResourceDefinition 2uasimojo/aws-efs-operator
1 participant
@2uasimojo