Use embed for static assets #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Fedosin
reviewed
Jun 18, 2021
assets/assets.go
Outdated
| "embed" | ||
| ) | ||
|
|
||
| //go:embed * |
There was a problem hiding this comment.
Suggested change
| //go:embed * | |
| //go:embed *.yaml rbac/*.yaml |
I recommend to explicitly define what files you are going to include in the embed.FS to prevent adding assets.go there.
jsafrane
force-pushed
the
embed
branch
3 times, most recently
from
571c9fb
to
06d1f80
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Move from bindata to embed to get rid of "make update".
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
bindataand usego:embedfor static assets.go:embedcan embed files only in the directory where it's used and its subdirs, therefore addassets.goto/assets/. No..or symlinks can be used to trickgo:embed.Updated library-go as a prerequisite.