DeploymentController: Do not overwrite manifest #1117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying hooks, make sure not to overwrite the original manifest. Some hooks may change the content later.
Example: a hook that replaces
${LOG_LEVEL}
withoperator.spec.logLevel
. As user modifies thelogLevel
, the controller + its hooks should replace${LOG_LEVEL}
with the current value, not with the value that was available on the first sync.