New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-18701: UPSTREAM: 1904, UPSTREAM: 1917, UPSTREAM: 1955: Update disk number table #49
OCPBUGS-18701: UPSTREAM: 1904, UPSTREAM: 1917, UPSTREAM: 1955: Update disk number table #49
Conversation
@tsmetana: This pull request references Jira Issue OCPBUGS-18701, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsmetana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@tsmetana: This pull request references Jira Issue OCPBUGS-18701, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b75c754
to
fd99279
Compare
/retest |
Use the pre merged build $ oc get no/pewang-0915s-qhk52-worker-southcentralus1-tqp64 -oyaml| grep 'instance-type'
beta.kubernetes.io/instance-type: Standard_B4as_v2
node.kubernetes.io/instance-type: Standard_B4as_v2
$ oc get csinode pewang-0915s-qhk52-worker-southcentralus1-tqp64 -ojsonpath='{.spec.drivers[?(@.name=="disk.csi.azure.com")].allocatable.count}'
8 |
/label qe-approved |
@tsmetana Upstream PR kubernetes-sigs#1917 refers to a cherry-pick PR, shouldn't we rather reference kubernetes-sigs#1916 instead which is the origin (in master)? The other two (1904 and 1955) seem ok. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lgtm |
@tsmetana: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@tsmetana: Jira Issue OCPBUGS-18701: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18701 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-azure-disk-csi-driver-container-v4.16.0-202312191909.p0.g02bbc78.assembly.stream for distgit ose-azure-disk-csi-driver. |
Cumulative backport of the updated max data disk count table from the latest upstream.