Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18701: UPSTREAM: 1904, UPSTREAM: 1917, UPSTREAM: 1955: Update disk number table #49

Merged

Conversation

tsmetana
Copy link
Member

Cumulative backport of the updated max data disk count table from the latest upstream.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 11, 2023
@openshift-ci-robot
Copy link

@tsmetana: This pull request references Jira Issue OCPBUGS-18701, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cumulative backport of the updated max data disk count table from the latest upstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@tsmetana
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 11, 2023
@openshift-ci-robot
Copy link

@tsmetana: This pull request references Jira Issue OCPBUGS-18701, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2023
@tsmetana
Copy link
Member Author

/retest

@Phaow
Copy link

Phaow commented Sep 15, 2023

Use the pre merged build 4.14.0-0.ci.test-2023-09-15-012215-ci-ln-kfslvtk-latest check the csinode object allocatable volumes count for Standard_B4as_v2 passed

$ oc get no/pewang-0915s-qhk52-worker-southcentralus1-tqp64 -oyaml| grep 'instance-type'
    beta.kubernetes.io/instance-type: Standard_B4as_v2
    node.kubernetes.io/instance-type: Standard_B4as_v2
$ oc get csinode pewang-0915s-qhk52-worker-southcentralus1-tqp64 -ojsonpath='{.spec.drivers[?(@.name=="disk.csi.azure.com")].allocatable.count}'
8

@Phaow
Copy link

Phaow commented Sep 15, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 15, 2023
@RomanBednar
Copy link

@tsmetana Upstream PR kubernetes-sigs#1917 refers to a cherry-pick PR, shouldn't we rather reference kubernetes-sigs#1916 instead which is the origin (in master)? The other two (1904 and 1955) seem ok.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2023
@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
Copy link

openshift-ci bot commented Dec 19, 2023

@tsmetana: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 02bbc78 into openshift:master Dec 19, 2023
9 checks passed
@openshift-ci-robot
Copy link

@tsmetana: Jira Issue OCPBUGS-18701: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18701 has been moved to the MODIFIED state.

In response to this:

Cumulative backport of the updated max data disk count table from the latest upstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-disk-csi-driver-container-v4.16.0-202312191909.p0.g02bbc78.assembly.stream for distgit ose-azure-disk-csi-driver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants