-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-947: support disabling default StorageClass via ClusterCSIDriver #42
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This failure is real (caused by bumping library-go): |
Note to self: review the driver parameters and discuss with the team what would be an appropriate value for the label (i.e. restricted or privileged). |
We agreed that it should be privileged by default (added here) but that we should allow the admin to change the value (added here). This means we use a secure default but allow the admin to specify a more permissive policy if their use case requires it. |
Basic functional test:
|
/retest |
/retitle STOR-947: support disabling default StorageClass via ClusterCSIDriver |
/lgtm |
1 similar comment
/lgtm |
/docs-approved |
Payload: 4.13.0-0.ci.test-2023-01-25-044031-ci-ln-8y8dp9t-latest Pending test on csi-ephemeral-volume-profile label Test Results: oc get sc change managed-csi volumeBindingMode Bydefault test change managed-csi allowVolumeExpansion to false Bydefault test change azurefile-csi allowVolumeExpansion to false oc get sc oc delete sc oc get sc Removed test change azurefile-csi allowVolumeExpansion to false Removed result oc get sc oc get sc change managed-csi volumeBindingMode Managed test change managed-csi allowVolumeExpansion to false Managed test change azurefile-csi allowVolumeExpansion to false oc get sc oc delete sc oc get sc oc get sc change managed-csi volumeBindingMode Unmanaged test change managed-csi allowVolumeExpansion to false Unmanaged test change azurefile-csi allowVolumeExpansion to false oc get sc oc delete sc oc get sc oc get sc oc get sc oc get sc and check azurefile-csi should not be there, managed-csi and testsc should be there oc get sc all should be present now managed-csi, azurefile-csi, testsc oc get sc azurefile-csi and managed-csi should be back to default oc get sc oc get sc oc get sc oc get sc azurefile-csi should not be there, managed-csi, testsc should be there managed-csi should remain |
/label px-approved |
/label docs-approved |
Verified: rohitpatil@ropatil-mac Downloads % oc label --overwrite csidriver file.csi.azure.com security.openshift.io/csi-ephemeral-volume-profile=restricted rohitpatil@ropatil-mac Downloads % oc label --overwrite csidriver file.csi.azure.com security.openshift.io/csi-ephemeral-volume-profile=privileged May need bit additional validation codecheck/Optional. rohitpatil@ropatil-mac Downloads % oc label --overwrite csidriver file.csi.azure.com security.openshift.io/csi-ephemeral-volume-profile=abcd /label qe-approved |
ETRYAGAIN? |
@dobsonj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/STOR-947
Marking this WIP until openshift/library-go#1441 merges.
/cc @openshift/storage