Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate BMH CRD with annotations needed for OpenShift #134

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

sadasu
Copy link

@sadasu sadasu commented Mar 15, 2021

  • Add a new kustomization file that adds the OpenShift annotations
  • Only on the OpenShift platform, use this file to generate the BMH CRD
  • Copy this generated CRD to the /manifests directory so that the CVO can install it

This fix is being added so that the BMH CRD does not have to be manually kept in sync with the BMO CRD.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@sadasu sadasu force-pushed the kustomize-bmh branch 2 times, most recently from 399b05a to 17ea960 Compare March 15, 2021 17:34
Dockerfile.ocp Outdated Show resolved Hide resolved
@sadasu
Copy link
Author

sadasu commented Mar 15, 2021

@andfasano - If you are Ok with the generic approach, this PR can be used just for adding ocp_kustomization.yaml. The Dockerfile.ocp changes will then be able to find this file in a later PR for the COPY command to be successful.

@sadasu
Copy link
Author

sadasu commented Mar 16, 2021

/cc @dhellmann
if this approach seems reasonable, I will split it into 2 PRs where the ocp_kustomization.yaml goes in first.

Dockerfile.ocp Outdated Show resolved Hide resolved
@sadasu sadasu changed the title WIP: Generate BMH CRD with annotations needed for OpenShift Generate BMH CRD with annotations needed for OpenShift Mar 16, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2021
@stbenjam
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 14004bc into openshift:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants