-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-3029: Merge upstream #255
OCPBUGS-3029: Merge upstream #255
Conversation
Fix the error that occur when executing `make docker` on a host that accesses the Internet through a proxy. Signed-off-by: Zou Yu <zouy.fnst@fujitsu.com>
Uplift golang to 1.19.6 and x/net to 0.7.0 due https://osv.dev/vulnerability/GO-2023-1571
📖 Mention CustomDeploy in the API docs
🐛 Accept http_proxy/https_proxy from env when `make docker`
🐛 uplift golang and x/net
Not running cleaning immediately after a failure may: 1. cause side effects when the machine powers back on into the old operating system (and e.g. rejoins the cluster as a worker); 2. confuse users with previous Ironic background since in Ironic a node cannot enter available without going through cleaning (unless disabled). This change moves hosts manageable -> available immediately. Users who want to opt-out have to set automatedCleanMode to disabled or detach the host. As of this change, we still give up cleaning after 3 attempts, so it's still possible to end up with an unclean host causing issues.
…he same time print ns to easier tracing allow namespace to continue with terminating when deprovisioning at the same time
🐛 allow namespace to continue terminating when bmh is deprovisioning at the same time
📖 add PreprovisioningImage documentation (closes metal3-io#1009)
🐛 Always retry failed cleaning on deprovisioning (fixes metal3-io#1182)
/assign @dtantsur |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks great, now waiting for the CI |
/retitle OCPBUGS-3029: Merge upstream |
@honza: This pull request references Jira Issue OCPBUGS-3029, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-metal-ipi-ovn-ipv6 I don't know why 1 node never called back to ironic-inspector, the other two have finished inspection and cleaning successfully. |
/lgtm |
@honza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@honza: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-3029 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.