Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-3029: Merge upstream #255

Merged

Conversation

honza
Copy link
Member

@honza honza commented Mar 1, 2023

No description provided.

dtantsur and others added 14 commits January 20, 2023 15:37
Fix the error that occur when executing `make docker` on a host that accesses the Internet through a proxy.

Signed-off-by: Zou Yu <zouy.fnst@fujitsu.com>
Uplift golang to 1.19.6 and x/net to 0.7.0 due
https://osv.dev/vulnerability/GO-2023-1571
📖 Mention CustomDeploy in the API docs
🐛 Accept http_proxy/https_proxy from env when `make docker`
Not running cleaning immediately after a failure may:

1. cause side effects when the machine powers back on into the old
   operating system (and e.g. rejoins the cluster as a worker);
2. confuse users with previous Ironic background since in Ironic a node
   cannot enter available without going through cleaning (unless disabled).

This change moves hosts manageable -> available immediately. Users who want
to opt-out have to set automatedCleanMode to disabled or detach the host.

As of this change, we still give up cleaning after 3 attempts, so it's
still possible to end up with an unclean host causing issues.
…he same time

print ns to easier tracing

allow namespace to continue with terminating when deprovisioning at the same time
 🐛 allow namespace to continue terminating when bmh is deprovisioning at the same time
📖  add PreprovisioningImage documentation (closes metal3-io#1009)
🐛 Always retry failed cleaning on deprovisioning (fixes metal3-io#1182)
@dtantsur
Copy link
Member

dtantsur commented Mar 1, 2023

/assign @dtantsur

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@dtantsur
Copy link
Member

dtantsur commented Mar 1, 2023

Looks great, now waiting for the CI

@dtantsur
Copy link
Member

dtantsur commented Mar 1, 2023

/retitle OCPBUGS-3029: Merge upstream

Also fixes https://issues.redhat.com/browse/OCPBUGS-2471

@openshift-ci openshift-ci bot changed the title Merge upstream OCPBUGS-3029: Merge upstream Mar 1, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 1, 2023
@openshift-ci-robot
Copy link

@honza: This pull request references Jira Issue OCPBUGS-3029, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

dtantsur commented Mar 2, 2023

/test e2e-metal-ipi-ovn-ipv6

I don't know why 1 node never called back to ironic-inspector, the other two have finished inspection and cleaning successfully.

@dtantsur
Copy link
Member

dtantsur commented Mar 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

@honza: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8e073a6 into openshift:master Mar 2, 2023
@openshift-ci-robot
Copy link

@honza: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3029 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants