Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1843950: remove infinite reconcile loop when fetching status annotation #75

Merged
merged 4 commits into from Jun 5, 2020
Merged

Bug 1843950: remove infinite reconcile loop when fetching status annotation #75

merged 4 commits into from Jun 5, 2020

Conversation

dhellmann
Copy link

Backport fixes from metal3-io#546 to OCP 4.6

@dhellmann
fix typo in variable name in controller tests
7f3d1f8 
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
create reusable functions for managing the status annotation content
b6a368b 
Add functions for marshalling and unmarshalling the data in the status
annotation. These will be useful in test code.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
ensure last updated is set when extracting status from annotation
7ef20ab 
If the status annotation is a partial version of the status struct it
will not include the LastUpdated value. This results in an infinite
loop, since hostHasStatus() only looks at the LastUpdated value to see
if it is filled in. This change removes the loop condition by ensuring
LastUpdated is set if the value from the annotation is empty.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
fix typo in output message for get-hardware-details
acdebc6 
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann requested a review from stbenjam June 5, 2020 11:57
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 5, 2020
@openshift-ci-robot
Copy link

@dhellmann: This pull request references Bugzilla bug 1843950, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1843950: remove infinite reconcile loop when fetching status annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@dhellmann dhellmann mentioned this pull request Jun 5, 2020
Merged
@zaneb
Copy link
Member

zaneb commented Jun 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 68685ef into openshift:master Jun 5, 2020
@openshift-ci-robot
Copy link

@dhellmann: Some pull requests linked via external trackers have merged: openshift/baremetal-operator#75. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1843950: remove infinite reconcile loop when fetching status annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

@honza honza Awaiting requested review from honza

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@zaneb zaneb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dhellmann @openshift-ci-robot @zaneb @openshift-merge-robot