Merge upstream 2020 06 04 #73
Conversation
operator-sdk 'up local' is now 'run --local' since v0.15.0. Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
…rkat-test-bmo ironic_bmo_variables.rc is removed
Metadata is required for cloud-init config drive which is used by Ironic. User should be able to create custom metadata in a secret and reference it in a BareMetalHost object. Change-Id: I0af37b39602280adb87ea72554833b500f58be71
Co-Authored-By: Doug Hellmann <dhellmann@redhat.com>
Change-Id: I7aa6b03293209dc87c4cb439198351fc371f1c9f
Change-Id: I66637b44516e736e4c617665df7c4c2f29547384
Empty namespaces in meta-data object references now default to the baremetalhost namespace Change-Id: Id3f4317e8444b287ee50fd85cae82227cfc4f1b0
Implement metadata interface for baremetal operator
Make BMO as part of CAPM3 deployment
OCP Baremetal IPI inside of Openstack environment requires the RootDeviceHint to be /dev/vdb when a pxeboot is performed given that OSP uses nova rescue and a pxeboot.img as /dev/vda.
Updated profile table to document openstack profile and disk
Add openstack profile
Put BMH status in annotation while reconciliation
operator-sdk removed the openapi generation command in v0.17.0.
Update operator-sdk
Since we updated to operator-sdk 0.17.0 developers need to install openapi-gen separately. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Running `make gosec` introduces changes to the local working directory, so let's update the dependencies properly. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
There's no sense in running the same job on both prow and travis. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
remove lint job from travis
The validation rules need to be set where the type is defined, not where it is used. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Add a make target 'generate-check' to ensure that both the code and CRDs have been regenerated for any change. Add hack/Dockerfile.operator-sdk to build an image containing the operator-sdk and other dependencies for the generator check. Add hack/generate.sh to run the check in a container using the image built by the new Dockerfile. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
fix kubebuilder validation for vlanid
…cies update vendored gosec dependencies
document openapi-gen dependency
set up check to ensure operator-sdk generation is done
Expand the docker make target to test both docker files that appear in the repo. The existing travis-ci job will try to build both images. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
gofmt does not return an error code if it can successfully find changes, but for the prow linter job we want this script to return an error if the code is not already formatted. Look for the list of files gofmt would change, and if the list is not empty then show the diffs it would make. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
|
So what was the outcome of this? I saw some chat on Slack that indicated maybe we need to pull in some changes to CAPBM. @dhellmann Could we get metal3-io#546 broken out to a separate PR? That's very important to make 4.5 GA. |
|
Older versions of ironic that do not have https://review.opendev.org/#/c/711816/ refuse to provision if the image information does not include 'image_checksum', even if the other hash value parameters are given. It seems safe to always pass the old name, so go ahead and do so. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
We will also need to pull the API changes into CAPBM before the root device hints will work properly, but (perhaps contrary to what I thought) we should be able to land this PR without first updating CAPBM because nothing should be using the new fields yet anyway. |
🏃 Add kustomizeconfig for namespace
support older ironic checksum expectations
Update doc link and operator-sdk command
|
/test e2e-metal-ipi |
Feat: add ibmc driver support
New BMH unhealthy annotation
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
📖 Add deployment documentation for BMO and Ironic
🏃 Change configMapGenerator behavior in kustomization and typo fixes
|
I see that this PR includes earlier changes to how we pass image checksums to ironic. We may need to add metal3-io#549 to support the older ironic we have in openshift. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| .PHONY: tools | ||
| tools: | ||
| @echo LDFLAGS=$(LDFLAGS) | ||
| go build -mod=vendor -o build/_output/bin/get-hardware-details cmd/get-hardware-details/main.go | ||
| go build -o build/_output/bin/get-hardware-details cmd/get-hardware-details/main.go |
There was a problem hiding this comment.
@honza This broke the OSE build -- how do we make sure your script preserves this?
There was a problem hiding this comment.
Good catch, I'll fix it ASAP.
This will go away if we upgrade to Golang 1.14. From the docs:
When the main module contains a top-level vendor directory and its go.mod file specifies go 1.14 or higher, the go command now defaults to -mod=vendor for operations that accept that flag. A new value for that flag, -mod=mod, causes the go command to instead load modules from the module cache (as when no vendor directory is present).
I'll see about upgrading the module to 1.14.
No description provided.