Merge changes from upstream as of 2020-07-02 #81
Conversation
dhellmann
commented
Jul 2, 2020
dhellmann
commented
- pkg/bmc: refactor to support all schemes
- Do not set the status annotation
- Round clock frequency to integer when setting HW details
- Remove Unhealthy annotation changes
Since float is not considered a valid type we will eventually have to convert this field to an integer. That's probably going to involve some very not-fun contortions regardless (see metal3-io/metal3-docs#101), but at the very least it's not helping anybody to continue creating Hosts with fractional values that will be non-round-trippable later.
Fix: Delete ironic-endpoint-keepalived container also while deleting other ironic containers
Add kashifest in the reviewers list
Round clock frequency to integer when setting HW details
⚠️ Remove old BMO & Ironic deployments
…-documentation Update Ironic Keepalived container documentation
In saveHostStatus, we get the BMH right after updating the annotation. In some cases the cache is not updated yet, causing an error in the status update. This could lead to a loop in some cases where the cache was slow to update as the annotations were always changed since operationHistory was changing every time (it uses the current time as end time for an operation). To solve this : - Discard operationHistory when comparing status annotation to current status to prevent unneeded updates of the annotation leading to additional conflicts - Do not throw an error upon conflict in saveHostStatus, but requeue after an info message
Fix SaveHostStatus infinite loop on update conflicts
…erse-jan Remove Unhealthy annotation changes
This commit removes the code setting the status annotation and requiring to reconcile the object twice. This is now done in CAPM3.
All of the redfish BMC's should support `+http` or `+https` explicitly, however it's not configured for any of the virtualmedia BMC's. This refactories the registerFactory code to allow specifying schemes for a BMC, and ensuring the schemed versions exist for every one. This keeps it explicit, so we can say which BMC's support specifying a scheme.
pkg/bmc: refactor to support all schemes
Do not set the status annotation
openshift-ci-robot
added
the
approved
|
There were some changes to the OWNERS file upstream which I removed during the merge. The main thing we want from this is to remove the code that was trying to set the status annotation. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test images |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold until CI settles down |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test e2e-metal-ipi |
4 similar comments
|
/test e2e-metal-ipi |
|
/test e2e-metal-ipi |
|
/test e2e-metal-ipi |
|
/test e2e-metal-ipi |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
