Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1932967: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network #123

Merged
merged 2 commits into from Mar 3, 2021
Merged

[release-4.6] Bug 1932967: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network #123

merged 2 commits into from Mar 3, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #108

/assign sferich888

@mandre
Allow running render when there is no VIP
3ccf35c 
There is no good reason for failing to get the NonVirtualIP when the
node can't have the VIP. This prevents from deploying additional
MachineSets to separate subnets.

This commit changes the getInterfaceAndNonVIPAddr() function to accept
cases where the node isn't attached to a subnet that includes the VIP.
In this case it simply returns the interface and IP address for the
default route.
@mandre
Node-ip falls back to IP address associated with default route
5d7f99f 
Previously, node-ip would fail when passing it VIPs and the node was not
on a subnet containing any of the VIPs. This prevents deploying
additional machine sets on separate subnets.

Now node-ip is a little bit smarter and uses the IP address associated
with the default route in case it cannot find the one for VIP subnet.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1894539 has been cloned as Bugzilla bug 1932967. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1932967: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network

In response to this:

[release-4.6] Bug 1894539: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1894539: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network [release-4.6] Bug 1932967: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network Feb 25, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 25, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1932967, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1894539 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1894539 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

In response to this:

[release-4.6] Bug 1932967: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@derekwaynecarr
Copy link
Member

(Patch Manager) met criteria, approved.

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit c08b59c into openshift:release-4.6 Mar 3, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1932967 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1932967: Allow baremetal-runtimecfg to function when the node isn't attached to the VIP network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet Awaiting requested review from bcrochet

@celebdor celebdor Awaiting requested review from celebdor

Assignees

@cybertron cybertron

@sferich888 sferich888

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @cybertron @derekwaynecarr @sferich888 @openshift-merge-robot @mandre