Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-6004: filter ovn fd69::2 ip from list of ips in case ovn #215

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jan 12, 2023

Adding network type in order to be able to filter ovn ipv6 ip

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@tsorya tsorya changed the title Filter ovn ipv6 ip OCPBUGS-2512: filter ovn fd69::2 ip from list of ips in case ovn Jan 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 14, 2023
@openshift-ci-robot
Copy link
Contributor

@tsorya: This pull request references Jira Issue OCPBUGS-2512, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding network type in order to be able to filter ovn ipv6 ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsorya
Copy link
Contributor Author

tsorya commented Jan 16, 2023

Looks good

Jan 16 15:33:25 02-00-00-4f-27-17 bash[18853]: time="2023-01-16T15:33:25Z" level=debug msg="Ignoring filtered address fd69::2/125"

@tsorya tsorya marked this pull request as ready for review January 16, 2023 15:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@tsorya
Copy link
Contributor Author

tsorya commented Jan 16, 2023

@tsorya
Copy link
Contributor Author

tsorya commented Jan 17, 2023

/test e2e-metal-ipi

Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a couple of printfs that should either be removed or converted to log calls.

pkg/utils/addresses.go Outdated Show resolved Hide resolved
pkg/utils/addresses.go Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

@tsorya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cybertron
Copy link
Member

/hold

We should resolve the bug situation with this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsorya tsorya changed the title OCPBUGS-2512: filter ovn fd69::2 ip from list of ips in case ovn OCPBUGS-6004: filter ovn fd69::2 ip from list of ips in case ovn Jan 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 18, 2023
@openshift-ci-robot
Copy link
Contributor

@tsorya: This pull request references Jira Issue OCPBUGS-6004, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mcornea

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding network type in order to be able to filter ovn ipv6 ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mcornea January 18, 2023 17:34
@cybertron
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2905c04 into openshift:master Jan 18, 2023
@openshift-ci-robot
Copy link
Contributor

@tsorya: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-6004 has not been moved to the MODIFIED state.

In response to this:

Adding network type in order to be able to filter ovn ipv6 ip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants