Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that Iptable rule being deleted #28

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Verify that Iptable rule being deleted #28

merged 1 commit into from
Oct 25, 2019

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Oct 22, 2019

Due to multi-process implementation of the monitor code (it's a corner case),
we may hit a race condition and as a result of this race, the iptable rule won't be deleted.
This fix verifies that the iptable rule is deleted.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2019
@yboaron
Copy link
Contributor Author

yboaron commented Oct 22, 2019

/assign @celebdor

@openshift-ci-robot
Copy link
Contributor

@yboaron: GitHub didn't allow me to assign the following users: celebdo.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @celebdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor Author

yboaron commented Oct 22, 2019

/cc @cybertron

@yboaron
Copy link
Contributor Author

yboaron commented Oct 22, 2019

/cc @bcrochet

@yboaron yboaron changed the title Verify that Iptable rule rapidly deleted Verify that Iptable rule being deleted Oct 22, 2019
@celebdor
Copy link
Contributor

@yboaron need to fix the go fmt

Due to multi-process implementation of the monitor code (it's a corner case),
 we may hit a race condition and as a result of this race, the iptable rule won't be deleted.
This fix verifies that the iptable rule is rapidly deleted.
@celebdor
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, cybertron, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a996458 into openshift:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants