-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that Iptable rule being deleted #28
Verify that Iptable rule being deleted #28
Conversation
/assign @celebdor |
@yboaron: GitHub didn't allow me to assign the following users: celebdo. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @cybertron |
/cc @bcrochet |
@yboaron need to fix the go fmt |
Due to multi-process implementation of the monitor code (it's a corner case), we may hit a race condition and as a result of this race, the iptable rule won't be deleted. This fix verifies that the iptable rule is rapidly deleted.
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cybertron, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Due to multi-process implementation of the monitor code (it's a corner case),
we may hit a race condition and as a result of this race, the iptable rule won't be deleted.
This fix verifies that the iptable rule is deleted.