make/targets: version binaries in _output #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
2uasimojo
reviewed
Jul 12, 2021
There was a problem hiding this comment.
- Can we add this for imagebuilder as well?
- This means
clean-foowill only clean the configured version offoo. Do we want to address that? Perhapsclean-fooshould remove_output/bin/foo*?
Oh, right, imagebuilder is installed into go, not in the repo :( Never mind. |
I'll propose a fup to discuss this. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2uasimojo
added a commit
to 2uasimojo/build-machinery-go
that referenced
this pull request
Jul 12, 2021
We provide a `clean-$foo` target for helper tools -- `$foo` in: - `controller-gen` - `kustomize` - `yaml-patch` - `yq` Since openshift#48 / aa83de7 we're installing those helpers to files with versioned names -- e.g. `yq-2.4.0` rather than just `yq` -- so `make clean-yq` would leave behind other versions of `yq`. With this commit, `make clean-$foo` will remove `${foo}*`, which should lasso all previous versions of a given helper, including one with the unversioned name, which better meets the consumer's expectation of what "clean $foo" should mean.
2uasimojo
added a commit
to 2uasimojo/build-machinery-go
that referenced
this pull request
Jul 12, 2021
We provide a `clean-$foo` target for helper tools -- `$foo` in: - `controller-gen` - `kustomize` - `yaml-patch` - `yq` Since openshift#48 / aa83de7 we're installing those helpers to files with versioned names -- e.g. `yq-2.4.0` rather than just `yq` -- so `make clean-yq` would leave behind other versions of `yq`. With this commit, `make clean-$foo` will remove `${foo}*`, which should lasso all previous versions of a given helper, including one with the unversioned name, which better meets the consumer's expectation of what "clean $foo" should mean.
2uasimojo
added a commit
to 2uasimojo/build-machinery-go
that referenced
this pull request
Jul 12, 2021
We provide a `clean-$foo` target for helper tools -- `$foo` in: - `controller-gen` - `kustomize` - `yaml-patch` - `yq` Since openshift#48 / aa83de7 we're installing those helpers to files with versioned names -- e.g. `yq-2.4.0` rather than just `yq` -- so `make clean-yq` would leave behind other versions of `yq`. With this commit, `make clean-$foo` will remove `${foo}*`, which should lasso all previous versions of a given helper, including one with the unversioned name, which better meets the consumer's expectation of what "clean $foo" should mean.
2uasimojo
added a commit
to 2uasimojo/build-machinery-go
that referenced
this pull request
Jul 12, 2021
We provide a `clean-$foo` target for helper tools -- `$foo` in: - `controller-gen` - `kustomize` - `yaml-patch` - `yq` Since openshift#48 / aa83de7 we're installing those helpers to files with versioned names -- e.g. `yq-2.4.0` rather than just `yq` -- so `make clean-yq` would leave behind other versions of `yq`. With this commit, `make clean-$foo` will remove `${foo}*`, which should lasso all previous versions of a given helper, including one with the unversioned name, which better meets the consumer's expectation of what "clean $foo" should mean.
2uasimojo
added a commit
to 2uasimojo/build-machinery-go
that referenced
this pull request
Aug 6, 2021
aa83de7 / openshift#48 added versioning for helper binaries. However, for kustomize, it assumed the install script would create the binary with the versioned name, which it doesn't. So consumers trying to use `$(KUSTOMIZE)`, which will be `_output/tools/bin/kustomize-v4.1.3`, will fail because it's actually at `_output/tools/bin/kustomize`. Furthermore, running `make ensure-kustomize` twice will cause the install script to fail because its target file already exists. Fix.
This was referenced Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.