Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1884610: Upgrade buildah to v1.16.4 #177

Merged

Conversation

nalind
Copy link
Member

@nalind nalind commented Oct 1, 2020

Bump github.com/containers/buildah from v1.16.0 to v1.16.4, mainly to pick up containers/buildah#2660 and containers/buildah#2668, but also pulling in containers/buildah#2653 to avoid a potential problem that could occur if/when the seccomp.json in the builder image is updated to start using "errno" actions.

@rhatdan
Copy link
Contributor

rhatdan commented Oct 1, 2020

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Contributor

LGTM

@TomSweeneyRedHat
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@TomSweeneyRedHat
Copy link
Contributor

/approve

@rhatdan
Copy link
Contributor

rhatdan commented Oct 1, 2020

/lgtm

@rhatdan
Copy link
Contributor

rhatdan commented Oct 1, 2020

/approve

@rhatdan
Copy link
Contributor

rhatdan commented Oct 1, 2020

@adambkaplan Can we get this merged?

@nalind
Copy link
Member Author

nalind commented Oct 1, 2020

@adambkaplan Can we get this merged?

Just found another problem that we'll want to fix, so this one will have to be updated or supplemented.

@nalind
Copy link
Member Author

nalind commented Oct 1, 2020

Just found another problem that we'll want to fix, so this one will have to be updated or supplemented.

That would be containers/buildah#2668, and a presumed follow-up to tag v1.16.4.

Bump github.com/containers/buildah from v1.16.0 to v1.16.4.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@nalind
Copy link
Member Author

nalind commented Oct 1, 2020

Updated to pull in v1.16.4.

@nalind
Copy link
Member Author

nalind commented Oct 2, 2020

/test e2e-aws

1 similar comment
@nalind
Copy link
Member Author

nalind commented Oct 2, 2020

/test e2e-aws

@nalind
Copy link
Member Author

nalind commented Oct 2, 2020

/retest

@adambkaplan
Copy link
Contributor

/retitle Bug 1884610: Upgrade buildah to v1.16.4

@openshift-ci-robot openshift-ci-robot changed the title bump github.com/containers/buildah Bug 1884610: Upgrade buildah to v1.16.4 Oct 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

@nalind: This pull request references Bugzilla bug 1884610, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1884610: Upgrade buildah to v1.16.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 2, 2020
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, nalind, rhatdan, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c2e4bcb into openshift:master Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

@nalind: All pull requests linked via external trackers have merged:

Bugzilla bug 1884610 has been moved to the MODIFIED state.

In response to this:

Bug 1884610: Upgrade buildah to v1.16.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind nalind deleted the update-buildah-1.16.3 branch October 2, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants