Bug 1916897: more automount of cluster trust bundle reverts; no longer automount /run/secrets

[gabemontero]

possible fix for https://bugzilla.redhat.com/show_bug.cgi?id=1916897

history of 4.6.0 bug fix that introduced regression that is being reverted noted in above BZ

[gabemontero]

none of the failures in e2e-aws run https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_builder/204/pull-ci-openshift-builder-master-e2e-aws/1351249633514360832 were in sig-builds

good sign

/test e2e-aws

[gabemontero]

and passing e2e-aws-builds

I think we go with this and when @adambkaplan gets back he can see what impact removing mounts.conf has on his optional re-intro of mounting the cluster trust store stuff

[openshift-ci-robot]

@gabemontero: This pull request references Bugzilla bug 1916897, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916897: more automount of cluster trust bundle reverts; no longer automount /run/secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/assign @smarterclayton

since he chimed in on the bug earlier today

[gabemontero]

/cherrypick release-4.6

[openshift-cherrypick-robot]

@gabemontero: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

For reference:

• the PR that introduced mounts.conf: Bug 1826183: Generate trust bundle for builds #158
• the PR that was suppose to revert the fix, but only removed the /etc/pki/ca-trust from mounts.conf: [release-4.6] Bug 1895093: Do not mount /etc/pki/ca-trust in builds #186

[gabemontero]

/assign @bparees
in addition to Clayton, since Ben was involved with #186

[gabemontero]

@hongkailiu - I'll start up a cluster with cluster-bot tomorrow using this PR and try out the BC at http://file.rdu.redhat.com/~hongkliu/dptp2021/bz1916897/content-mirror/app.ci.bc.content-mirror.yaml

[bparees]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@gabemontero: All pull requests linked via external trackers have merged:

• openshift/builder#204

Bugzilla bug 1916897 has been moved to the MODIFIED state.

In response to this:

Bug 1916897: more automount of cluster trust bundle reverts; no longer automount /run/secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@gabemontero: new pull request created: #205

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.