Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1940052: retry image pulls during builds #226

Merged
merged 1 commit into from Mar 23, 2021
Merged

[release-4.7] Bug 1940052: retry image pulls during builds #226

merged 1 commit into from Mar 23, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #222

/assign gabemontero

@nalind
Retry image pulls during builds
036b796 
Have the builder retry if it fails to pull an image, one which we didn't
pre-pull ourselves, during the build.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1937535 has been cloned as Bugzilla bug 1940052. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1940052: retry image pulls during builds

In response to this:

[release-4.7] Bug 1937535: retry image pulls during builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1937535: retry image pulls during builds [release-4.7] Bug 1940052: retry image pulls during builds Mar 17, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 17, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1940052, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1937535 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1937535 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

[release-4.7] Bug 1940052: retry image pulls during builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 17, 2021
@gabemontero
Copy link
Contributor

/lgtm

/assign @adambkaplan
for approve label

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@gabemontero
Copy link
Contributor

gabemontero commented Mar 17, 2021 •
edited

Will need openshift/origin#25884 to merge first for image-eco to pass

That is currently blocked by e2e-aws-proxy and e2e-gcp-disruptive bzs

@gabemontero
Copy link
Contributor

/test e2e-aws
/test e2e-aws-builds

@gabemontero
Copy link
Contributor

/test e2e-aws-image-ecosystem

@gabemontero
Copy link
Contributor

gabemontero commented Mar 18, 2021 •
edited

the e2e-aws-builds failure will be fixed by openshift/origin#25966 from @adambkaplan

@gabemontero
Copy link
Contributor

openshift/origin#25966 has merged

/retest

@gabemontero
Copy link
Contributor

all green tests with this 4.7 openshift/builder PR @adambkaplan .... please approve wygtc

adambkaplan
adambkaplan approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2021
@gabemontero
Copy link
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
ci/prow/e2e-aws-image-ecosystem 036b796 link /test e2e-aws-image-ecosystem

Full PR test history. Your PR dashboard.

image eco passed but a sig-api-machinery flake occurred as the test cluster was shutting down

/test e2e-aws-image-ecosystem

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor

kubelet non-graceful shutdown on e2e-aws

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@xiuwang
Copy link

xiuwang commented Mar 23, 2021

Validate the pr with below scenarios, works as expected.
Scenario1: Specify a private image as source image and add pull secret, trigger build
Scenario2: Trigger build with pull private image, set invaild secret at first, then correct secret quickly.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, openshift-cherrypick-robot, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor

e2e-aws still full of cannot pull images from quay.io

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 5384718 into openshift:release-4.7 Mar 23, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1940052 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1940052: retry image pulls during builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@adambkaplan adambkaplan

@gabemontero gabemontero

@xiuwang xiuwang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @gabemontero @openshift-bot @xiuwang @adambkaplan @ecordell @openshift-merge-robot @nalind