-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1939477: Update tests to use Ruby 2.7 #25966
[release-4.7] Bug 1939477: Update tests to use Ruby 2.7 #25966
Conversation
This test uses centos7 version, which doesn't have a 2.7 tag, intentionally split into 2.7-ubi8 and -ubi7
@openshift-cherrypick-robot: Bugzilla bug 1939232 has been cloned as Bugzilla bug 1939477. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939477, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/bugzilla refresh |
@adambkaplan: This pull request references Bugzilla bug 1939477, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xiuwang this is a test only change to clear CI for urgent backports. We probably do not need you to do manual verification. |
/retest Builds test failed due to kubelet graceful termination flake/failure |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
}, | ||
"from": { | ||
"kind": "DockerImage", | ||
"name": "registry.centos.org/centos/ruby-26-centos7:latest" | ||
"name": "registry.centos.org/centos/ruby-27-centos7:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image does not exist, could we push it firstly?
$skopeo inspect docker://registry.centos.org/centos/ruby-27-centos7:latest
FATA[0002] manifest unknown: manifest unknown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the case, then I don't think we are using this example in test code. If that is the case, I would remove it as this capability has been replaced by the samples operator.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot, xiuwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/close |
@adambkaplan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939477. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
/close cancel |
@adambkaplan: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939477, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bparees |
no, only proxy was made optional. |
/retest |
1 similar comment
/retest |
So the last image eco passed with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25966/pull-ci-openshift-origin-release-4.7-e2e-gcp-image-ecosystem/1372345360952856576 That should be confirmation that the limit route name length fix that merged last night is working for this PR too |
confirmed that the e2e-gcp-disruptive permfail is https://bugzilla.redhat.com/show_bug.cgi?id=1886160 which has not even merged into 4.8 yet, much less backported into 4.7 that said, I looked at a recent e2e-gcp-disruptve run on a master branch openshift/origin PR @adambkaplan @bparees @vrutkovs and while it passes, that particular test case is not in the list of passing tests passed last night And sure enough, I'll take this over to 4-dev-triage, but I think we should make it optional / get it skippable in 4.7 |
openshift/release#16950 is making e2e-gcp-disruptive optional with 4.7 |
/override ci/prow/e2e-gcp-disruptive |
@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-gcp-disruptive In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override ci/prow/e2e-gcp-upgrade |
@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-gcp-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1939477 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #25949
/assign adambkaplan