Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 1939477: Update tests to use Ruby 2.7 #25966

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #25949

/assign adambkaplan

This test uses centos7 version, which doesn't have a 2.7 tag, intentionally split into 2.7-ubi8 and -ubi7
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1939232 has been cloned as Bugzilla bug 1939477. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1939477: Update tests to use Ruby 2.7

In response to this:

[release-4.7] Bug 1939232: Update tests to use Ruby 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1939232: Update tests to use Ruby 2.7 [release-4.7] Bug 1939477: Update tests to use Ruby 2.7 Mar 16, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939477, which is invalid:

  • expected dependent Bugzilla bug 1939232 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1939477: Update tests to use Ruby 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2021
@adambkaplan
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Bugzilla bug 1939477, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939232 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1939232 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@adambkaplan
Copy link
Contributor

@xiuwang this is a test only change to clear CI for urgent backports. We probably do not need you to do manual verification.

@adambkaplan
Copy link
Contributor

/retest

Builds test failed due to kubelet graceful termination flake/failure

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

},
"from": {
"kind": "DockerImage",
"name": "registry.centos.org/centos/ruby-26-centos7:latest"
"name": "registry.centos.org/centos/ruby-27-centos7:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image does not exist, could we push it firstly?
$skopeo inspect docker://registry.centos.org/centos/ruby-27-centos7:latest
FATA[0002] manifest unknown: manifest unknown

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the case, then I don't think we are using this example in test code. If that is the case, I would remove it as this capability has been replaced by the samples operator.

@xiuwang
Copy link
Contributor

xiuwang commented Mar 18, 2021

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

/close

@openshift-ci-robot
Copy link

@adambkaplan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939477. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

[release-4.7] Bug 1939477: Update tests to use Ruby 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/reopen

@adambkaplan
Copy link
Contributor

/close cancel

@openshift-ci-robot
Copy link

@adambkaplan: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1939477, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939232 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1939232 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

[release-4.7] Bug 1939477: Update tests to use Ruby 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

@bparees e2e-gcp-disruptive still shows up as "required" - I thought this test was made optional?

@bparees
Copy link
Contributor

bparees commented Mar 18, 2021

@bparees e2e-gcp-disruptive still shows up as "required" - I thought this test was made optional?

no, only proxy was made optional.
openshift/release#16903

@vikaslaad
Copy link

/retest

1 similar comment
@vikaslaad
Copy link

/retest

@gabemontero
Copy link
Contributor

So the last image eco passed with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25966/pull-ci-openshift-origin-release-4.7-e2e-gcp-image-ecosystem/1372345360952856576

That should be confirmation that the limit route name length fix that merged last night is working for this PR too

@gabemontero
Copy link
Contributor

confirmed that the e2e-gcp-disruptive permfail is https://bugzilla.redhat.com/show_bug.cgi?id=1886160 which has not even merged into 4.8 yet, much less backported into 4.7

that said, I looked at a recent e2e-gcp-disruptve run on a master branch openshift/origin PR @adambkaplan @bparees @vrutkovs and while it passes, that particular test case is not in the list of passing tests

See https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25978/pull-ci-openshift-origin-master-e2e-aws-disruptive/1372337842969120768

passed last night

And sure enough, [sig-etcd][Feature:DisasterRecovery][Disruptive] [Feature:EtcdRecovery] Cluster should restore itself after quorum loss is in the skipped list !!

I'll take this over to 4-dev-triage, but I think we should make it optional / get it skippable in 4.7

@gabemontero
Copy link
Contributor

openshift/release#16950 is making e2e-gcp-disruptive optional with 4.7

@bparees
Copy link
Contributor

bparees commented Mar 18, 2021

/override ci/prow/e2e-gcp-disruptive

@openshift-ci-robot
Copy link

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-gcp-disruptive

In response to this:

/override ci/prow/e2e-gcp-disruptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikaslaad
Copy link

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-proxy 3253797 link /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor

bparees commented Mar 18, 2021

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 98285f8 into openshift:release-4.7 Mar 18, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1939477 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1939477: Update tests to use Ruby 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.