Fix proxy.md #116
Fix proxy.md #116
Conversation
|
/lgtm |
|
cc: @xenolinux |
openshift-ci
bot
added
lgtm
|
/assign @xenolinux (JFYI, installing the operator from the GitHub source uses operator name as: "cert-manager-operator" while when installed from the productized build on an OpenShift cluster it is "openshift-cert-manager-operator" which the reason by the .md docs in this repo may contain different values to what's expected in openshift-docs) TIA |
|
/label px-approved |
openshift-ci
bot
added
px-approved
docs/proxy.md
Outdated
| oc -n cert-manager-operator patch subscription cert-manager-operator --type='merge' -p '{"spec":{"config":{"env":[{"name":"TRUSTED_CA_CONFIGMAP_NAME","value":"trusted-ca"}]}}}' | ||
| ``` | ||
| ```bash | ||
| oc -n cert-manager-operator patch subscription openshift-cert-manager-operator --type='merge' -p '{"spec":{"config":{"env":[{"name":"TRUSTED_CA_CONFIGMAP_NAME","value":"trusted-ca"}]}}}' |
There was a problem hiding this comment.
@xingxingxia after giving this one a re-thought, IMO can we please keep this one as is in case of this GitHub repo and just update this to use "openshift-cert-manager-operator" only in https://github.com/openshift/openshift-docs would be totally in favour of getting the docs updated.
The rationale behind it being: users installing the operator from GitHub source will continue to use subscription name as "cert-manager-operator" while those who installed the productized RH version of the operator from OperatorHub (rh operator-index) would have subscription object named "openshift-cert-manager-operator" (which is becuase we patch the operator package id in midstream before building the productized version).
cc: @xenolinux
There was a problem hiding this comment.
Sure, but I updated with placeholder "<subscription_name>", is it fine?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh, thejasn, xingxingxia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
@xingxingxia: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @swghosh @thejasn
The display in https://github.com/openshift/cert-manager-operator/blob/master/docs/proxy.md does not hide ```bash, it displays as:
Also, the subscription name (if installed via web) is
openshift-cert-manager-operatorinstead. https://docs.openshift.com/container-platform/4.12/security/cert_manager_operator/cert-manager-operator-proxy.html needs update to besubscription openshift-cert-manager-operatoras well (didn't catch this when GA sorry), CC @bergerhoffer .