Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-9960: Add disable operand delete annotation #122

Conversation

thejasn
Copy link
Contributor

@thejasn thejasn commented May 8, 2023

Description

Add annotation to disable operand delete option on console. This acts as a check, to ensure deletion is done manually.

cc: @xenolinux docs updated required for manual deletion

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@thejasn
Copy link
Contributor Author

thejasn commented May 8, 2023

/cc @swghosh

@openshift-ci openshift-ci bot requested a review from swghosh May 8, 2023 11:33
@thejasn thejasn changed the title Add disable operand delete annotation OCPBUGS-9960: Add disable operand delete annotation May 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 8, 2023
@openshift-ci-robot
Copy link

@thejasn: This pull request references Jira Issue OCPBUGS-9960, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@thejasn: This pull request references Jira Issue OCPBUGS-9960, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Description

Add annotation to disable operand delete option on console. This acts as a check, to ensure deletion is done manually.

cc: @xenolinux docs updated required for manual deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh
Copy link
Member

swghosh commented May 8, 2023

/retest-required

@swghosh
Copy link
Member

swghosh commented May 8, 2023

/lgtm
/cc @davemulford
for px-approved
/cc @xenolinux
for docs-approved
/jira cc-qa
@xingxingxia for qe-approved (feel free to test it post-merge after this arrives in next staging build)

@openshift-ci-robot
Copy link

@swghosh: This pull request references Jira Issue OCPBUGS-9960, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/lgtm
/cc @davemulford
for px-approved
/cc @xenolinux
for docs-approved
/jira cc-qa
for qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@swghosh
Copy link
Member

swghosh commented May 8, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 8, 2023
@openshift-ci-robot
Copy link

@swghosh: This pull request references Jira Issue OCPBUGS-9960, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia May 8, 2023 13:19
@xenolinux
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label May 8, 2023
@davemulford
Copy link

@thejasn is there anything in the UI that instructs the customer to manually delete the operands before uninstalling the operator?

@thejasn
Copy link
Contributor Author

thejasn commented May 8, 2023

@thejasn is there anything in the UI that instructs the customer to manually delete the operands before uninstalling the operator?

There is a follow up docs task which will add steps to the uninstall section of the operator documentation.

@davemulford
Copy link

Thank you! LGTM
/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label May 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@thejasn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xingxingxia
Copy link
Contributor

/label qe-approved
Thanks!

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3325e3a into openshift:master May 9, 2023
@openshift-ci-robot
Copy link

@thejasn: Jira Issue OCPBUGS-9960: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-9960 has been moved to the MODIFIED state.

In response to this:

Description

Add annotation to disable operand delete option on console. This acts as a check, to ensure deletion is done manually.

cc: @xenolinux docs updated required for manual deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. docs-approved Signifies that Docs has signed off on this PR jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants