Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 4.4.13 in fast channel(s) #332

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Enable 4.4.13 in fast channel(s) #332

merged 1 commit into from
Jul 21, 2020

Conversation

openshift-bot
Copy link

Please merge as soon as https://errata.devel.redhat.com/advisory/56873 is shipped live OR if a Cincinnati-first release is approved.

This should provide adequate soak time for candidate channel PR #331

This PR will also enable upgrades from 4.4.13 to releases in fast-4.5

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@openshift-bot openshift-bot mentioned this pull request Jul 15, 2020
Merged
@wking
Copy link
Member

wking commented Jul 17, 2020

Reviewing update CI:

  • OSProvisioningTimedOut installing 4.3.27. rhbz#1779375 tracks this (currently deferred), but not a 4.4.13 problem.
  • 4.4.10 -> 4.4.13 failed on Kubernetes API disruption, tracked in the cross-platform umbrella rhbz#1845411.
  • 4.4.12 -> 4.4.13 failed on openshift-apiserver is reporting a failure: APIServerDeploymentDegraded. Reopened rhbz#1817588 discussing this failure.
  • Other failures I haven't had time to look into yet ;).

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2020
vrutkovs
vrutkovs approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2020
@sdodson
Copy link
Member

sdodson commented Jul 21, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 087e272 into master Jul 21, 2020
@sdodson sdodson deleted the pr-fast-4.4.13 branch October 12, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
6 participants
@openshift-bot @wking @openshift-ci-robot @sdodson @vrutkovs @openshift-merge-robot