OWNERS: Bugzilla product should be "OpenShift Update Service" #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
Based on Scott's [1]: > It's used downstream to facilitate mapping to BZ Components. I'm not sure if this property matters to us, because we are a separate Red Hat product, not a component under the OpenShift Container Project product. But 'Cincinnati Operator' no longer exists anywhere, so pointing folks at our current product name isn't breaking it any worse. $ curl -s 'https://bugzilla.redhat.com/rest/product/OpenShift%20Update%20Service' | jq -r '.products[].name' OpenShift Update Service $ curl 'https://bugzilla.redhat.com/rest/product/Cincinnati%20Operator' {"products":[]} [1]: openshift/cluster-version-operator#344 (comment)
wking
force-pushed
the
bugzilla-component
branch
from
24845f6
to
727a3c5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/cincinnati-operator
that referenced
this pull request
Nov 18, 2020
I'd updated the value in 727a3c5 (OWNERS: Bugzilla product should be "OpenShift Update Service", 2020-11-10, openshift#77), but at that point I was uncertain about how to handle Bugzilla products vs. components. Today, Luke pointed me towards the consuming code [1], showing that we should have used the 'product' key, overriding ART's "OpenShift Container Platform" default product. [1]: https://github.com/openshift/doozer/blob/231d240702a5c22da488fa241bc76df416acee6a/doozerlib/metadata.py#L288-L343
wking
added a commit
to wking/cincinnati-operator
that referenced
this pull request
Nov 18, 2020
I'd updated the value in 727a3c5 (OWNERS: Bugzilla product should be "OpenShift Update Service", 2020-11-10, openshift#77), but at that point I was uncertain about how to handle Bugzilla products vs. components. Today, Luke pointed me towards the consuming code [1], showing that we should have used the 'product' key, overriding ART's "OpenShift Container Platform" default product. [1]: https://github.com/openshift/doozer/blob/231d240702a5c22da488fa241bc76df416acee6a/doozerlib/metadata.py#L288-L343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @sdodson's comment:
I'm not sure if this property matters to us, because we are a separate Red Hat product, not a component under the OpenShift Container Project product. But
Cincinnati Operatorno longer exists anywhere, so pointing folks at our current product name isn't breaking it any worse.