Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS: Add component Cluster Version Operator #344

Merged
merged 1 commit into from Apr 8, 2020
Merged

OWNERS: Add component Cluster Version Operator #344

merged 1 commit into from Apr 8, 2020

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Apr 7, 2020

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Apr 8, 2020

What is this about? I don't see anything about component in the upstream docs linked from the file header.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member Author

sdodson commented Apr 8, 2020

What is this about? I don't see anything about component in the upstream docs linked from the file header.

It's used downstream to facilitate mapping to BZ Components.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member Author

sdodson commented Apr 8, 2020

/override ci/prow/integration

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/integration

In response to this:

/override ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 21c4c35 into openshift:master Apr 8, 2020
wking added a commit to wking/cluster-version-operator that referenced this pull request Apr 13, 2020
@wking
OWNERS: Document 'component' property
d89b9f9 
Example of OpenShift components:

  $ curl -sH Accept:application/json -H Content-Type:application/json --data '{"jsonrpc":"2.0","method":"SelectizeJS.list_components","id":1,"params":[{"term":"..","descrs":1,"disabled":0,"product":"v314_product"}]}' https://bugzilla.redhat.com/jsonrpc.cgi | jq -r '[.result[].value] | sort[]'
  Build
  Cincinnati
  Cloud Compute
  Cloud Credential Operator
  Cluster Loader
  Cluster Version Operator
  Compliance Operator
  ...

Based on Scott's [1]:

> It's used downstream to facilitate mapping to BZ Components.

[1]: openshift#344 (comment)
@wking wking mentioned this pull request Apr 13, 2020
Merged
wking added a commit to wking/cluster-bootstrap that referenced this pull request Jul 17, 2020
@wking
OWNERS: Add Bugzilla component
e31e328 
Example of OpenShift components:

  $ curl -sH Accept:application/json -H Content-Type:application/json --data '{"jsonrpc":"2.0","method":"SelectizeJS.list_components","id":1,"params":[{"term":"..","descrs":1,"disabled":0,"product":"v314_product"}]}' https://bugzilla.redhat.com/jsonrpc.cgi | jq -r '[.result[].value] | sort[]'
  Build
  Cincinnati
  Cloud Compute
  Cloud Credential Operator
  Cluster Loader
  Cluster Version Operator
  Compliance Operator
  ...

Based on Scott's [1]:

> It's used downstream to facilitate mapping to BZ Components.

[1]: openshift/cluster-version-operator#344 (comment)
@wking wking mentioned this pull request Jul 17, 2020
Merged
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 10, 2020
@wking
OWNERS: Bugzilla product should be "OpenShift Update Service"
24845f6 
Based on Scott's [1]:

> It's used downstream to facilitate mapping to BZ Components.

I'm not sure if this property matters to us, because we are a separate
Red Hat product, not a component under the OpenShift Container Project
product.  But 'Cincinnati Operator' no longer exists anywhere, so
pointing folks at our current product name isn't breaking it any
worse.

[1]: openshift/cluster-version-operator#344 (comment)
@wking wking mentioned this pull request Nov 10, 2020
Merged
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 10, 2020
@wking
OWNERS: Bugzilla product should be "OpenShift Update Service"
727a3c5 
Based on Scott's [1]:

> It's used downstream to facilitate mapping to BZ Components.

I'm not sure if this property matters to us, because we are a separate
Red Hat product, not a component under the OpenShift Container Project
product.  But 'Cincinnati Operator' no longer exists anywhere, so
pointing folks at our current product name isn't breaking it any
worse.

$ curl -s 'https://bugzilla.redhat.com/rest/product/OpenShift%20Update%20Service' | jq -r '.products[].name'
OpenShift Update Service
$ curl 'https://bugzilla.redhat.com/rest/product/Cincinnati%20Operator'
{"products":[]}

[1]: openshift/cluster-version-operator#344 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@wking wking Awaiting requested review from wking

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sdodson @abhinavdahiya @openshift-ci-robot @openshift-bot @wking @openshift-merge-robot