Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: 1776980 Dynamically detect if Azure credentials can mint or fallback to passthrough #141

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Bug: 1776980 Dynamically detect if Azure credentials can mint or fallback to passthrough #141

merged 3 commits into from
Nov 28, 2019

Conversation

mjudeikis
Copy link
Contributor

Enables azure checking for mint and passthrough modes

/cc @jim-minter @dgoodwin @joelddiaz

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2019
@mjudeikis mjudeikis changed the title enable azure passthrough [wip] enable azure passthrough Nov 27, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2019
@jim-minter jim-minter mentioned this pull request Nov 27, 2019
Closed
joelddiaz
joelddiaz reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. just some comments/suggestions.

pkg/controller/secretannotator/azure/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler_test.go Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controller/secretannotator/azure/validate.go Outdated Show resolved Hide resolved
@mjudeikis mjudeikis changed the title [wip] enable azure passthrough enable azure passthrough Nov 28, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2019
@dgoodwin
Copy link
Contributor

/test e2e-azure

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mjudeikis
Copy link
Contributor Author

mjudeikis commented Nov 28, 2019 via email

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2019
@mjudeikis
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2019
@mjudeikis
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit abd3b82 into openshift:master Nov 28, 2019
@dgoodwin
Copy link
Contributor

/retitle Bug: 1776980 Dynamically detect if Azure credentials can mint or fallback to passthrough

@openshift-ci-robot openshift-ci-robot changed the title enable azure passthrough Bug: 1776980 Dynamically detect if Azure credentials can mint or fallback to passthrough Nov 28, 2019
@dgoodwin
Copy link
Contributor

/bugzilla refresh

@dgoodwin
Copy link
Contributor

/cherrypick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2019
Merged
@openshift-cherrypick-robot
Copy link

@dgoodwin: new pull request created: #142

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@mjudeikis: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-azure 973107d link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin
Copy link
Contributor

/test e2e-azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelddiaz joelddiaz joelddiaz left review comments

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@jim-minter jim-minter Awaiting requested review from jim-minter

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mjudeikis @dgoodwin @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @joelddiaz @openshift-merge-robot