Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1781792: Use CloudCredentialOperator as alert prefix for humans #144

Merged
merged 1 commit into from Dec 5, 2019

Conversation

smarterclayton
Copy link
Contributor

CC is far too generic to be an alert name and confused an
admin (me) when looking at clusters.

Thank you for adding alerts

CC is far too generic to be an alert name.
@smarterclayton
Copy link
Contributor Author

/cherry-pick release-4.3

@openshift-cherrypick-robot

@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2019
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 83cfad3 into openshift:master Dec 5, 2019
@openshift-cherrypick-robot

@smarterclayton: #144 failed to apply on top of branch "release-4.3":
```Applying: Use CloudCredentialOperator as alert prefix for humans
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M config/manager/prometheusrule.yaml
M manifests/05_deployment.yaml
M pkg/assets/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/assets/bindata.go
CONFLICT (content): Merge conflict in pkg/assets/bindata.go
Auto-merging manifests/05_deployment.yaml
Auto-merging config/manager/prometheusrule.yaml
CONFLICT (content): Merge conflict in config/manager/prometheusrule.yaml
Patch failed at 0001 Use `CloudCredentialOperator` as alert prefix for humans


<details>

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/144#issuecomment-562286916):

>/cherry-pick release-4.3


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
</details>

@joelddiaz joelddiaz changed the title Use CloudCredentialOperator as alert prefix for humans Bug 1781792: Use CloudCredentialOperator as alert prefix for humans Dec 10, 2019
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1781792 has been moved to the MODIFIED state.

In response to this:

Bug 1781792: Use CloudCredentialOperator as alert prefix for humans

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants