Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide region when setting up an AWS client #158

Merged

Conversation

joelddiaz
Copy link
Contributor

this allows the client setup code to insert the region info, which in turn allows the AWS SDK to use the alternative API endpoints when connecting to the AWS China regions.

also reorder parameters so we are consistently using region before infraName.

this allows the client setup code to insert the region info, which in turn allows the AWS SDK to use the alternative API endpoints when connecting to the AWS China regions.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@joelddiaz
Copy link
Contributor Author

@dgoodwin this is good for review now

@dgoodwin
Copy link
Contributor

dgoodwin commented Mar 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9869473 into openshift:master Mar 2, 2020
@wanghaoran1988
Copy link
Member

/cherrypick release-4.4

@openshift-cherrypick-robot

@wanghaoran1988: new pull request created: #160

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants