openshift-ingress: Change namespace and permissions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
Move the "cloud-credentials" secret from the operand namespace
("openshift-ingress") to the operator namespace
("openshift-ingress-operator"): The operator already has permission to read
secrets in its own namespace, but not from its operands', and the
"cloud-credentials" secret is an input to the operator, not an operand, so
having the secret in the operator's namespace simplifies RBAC and is more
consistent with how we place other resources related to the operator.
Refine the set of permissions for cluster-ingress-operator: The operator
needs to be able to look up Route 53 zones using the ListHostedZones and
GetResources APIs, list load balancers using DescribeLoadBalancers, update
hosted zones using the ChangeResourceRecordSets API, and nothing else.
This commit is related to NE-140.
https://jira.coreos.com/browse/NE-140
* manifests/03-cred-openshift-ingress.yaml: Change the namespace for the
secret from "openshift-ingress" to "openshift-ingress-operator".
Update the permissions to be exactly what cluster-ingress-operator needs.
Miciah
force-pushed
the
NE-140-openshift-ingress-change-namespace-and-permission
branch
from
db6e45e
to
b78cbd6
Compare
/retest |
|
/lgtm Thanks Miciah! Look good to you @ironcladlou ? /hold |
openshift-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@dgoodwin @Miciah looks fine to me in theory, but since openshift/origin#21617 is still pending we have no automated regression testing. Does this sequence make sense:
Future changes to cloud-credentials-operator which could impact ingress DNS management should then be tested via e2e-aws. |
|
Sounds good to me. Just cancel the hold when you're ready. |
|
@ironcladlou, your plan looks fine. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
cloud-credentialssecret from the operand namespace (openshift-ingress) to the operator namespace (openshift-ingress-operator): The operator already has permission to read secrets in its own namespace, but not from its operands', and thecloud-credentialssecret is an input to the operator, not an operand, so having the secret in the operator's namespace simplifies RBAC and is more consistent with how we place other resources related to the operator.Refine the set of permissions for cluster-ingress-operator: The operator needs to be able to look up Route 53 zones using the
ListHostedZonesandGetResourcesAPIs, list load balancers usingDescribeLoadBalancers, update hosted zones using theChangeResourceRecordSetsAPI, and nothing else.This PR is related to NE-140.
manifests/03-cred-openshift-ingress.yaml: Change the namespace for the secret fromopenshift-ingresstoopenshift-ingress-operator.Update the permissions to be exactly what cluster-ingress-operator needs.
@ironcladlou