-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use credentials from cloud-credential-operator #106
Use credentials from cloud-credential-operator #106
Conversation
Replace use of kube-system cloud credentials by using openshift-ingress cloud credentials courtesy of cloud-credential-operator. This commit resolves NE-140. https://jira.coreos.com/browse/NE-140 * cmd/cluster-ingress-operator/main.go (cloudCredentialsSecretName): New constant with the name of the cloud credentials secret that cloud-credential-operator creates for cluster-ingress-operator. (main): Pass operatorNamespace to createDNSManager. (createDNSManager): Instead of using the "aws-creds" secret from the "kube-system" namespace, use the "cloud-credentials" secret from the operator's namespace. * manifests/01-kube-system-aws-creds-role-binding.yaml: Deleted; the operator no longer needs to read the secret from the kube-system namespace.
Should hopefully see wildcard DNS test fail in e2e-aws now... /retest |
/retest |
1 similar comment
/retest |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Replace use of kube-system cloud credentials by using openshift-ingress cloud credentials courtesy of cloud-credential-operator.
This PR resolves NE-140.
This PR depends on openshift/cloud-credential-operator#16.
cmd/cluster-ingress-operator/main.go
(cloudCredentialsSecretName
): New constant with the name of the cloud credentials secret that cloud-credential-operator creates for cluster-ingress-operator.(
main
): PassoperatorNamespace
tocreateDNSManager
.(
createDNSManager
): Instead of using theaws-creds
secret from thekube-system
namespace, use thecloud-credentials
secret from the operator's namespace.manifests/01-kube-system-aws-creds-role-binding.yaml
: Deleted; the operator no longer needs to read the secret from thekube-system
namespace.