Bug 1954765: v1beta1 to v1 mutatingwebhookconfiguration #333
Conversation
openshift-ci-robot
added
the
approved
joelddiaz
force-pushed
the
v1-mutatingwebhook
branch
from
b783b33
to
12908d4
Compare
joelddiaz
changed the title
New kubernetes versions have removed support for v1beta1 MutatingWebhookConfiguration CRs. Migrate to deploying v1. Update pod-identity-webhook ClusterRole to grant permissions around certificatesigningrequests (fixes `E0503 15:37:23.227864 1 certificate_manager.go:434] Failed while requesting a signed certificate from the master: cannot create certificate signing request : certificatesigningrequests.certificates.k8s.io is forbidden: User "system:serviceaccount:openshift-cloud-credential-operator:pod-identity-webhook" cannot creat e resource "certificatesigningrequests" in API group "certificates.k8s.io" at the cluster scope`). Add the newly required `admissionReviewVersions` field to the v1 MutatingWebhookConfiguration. Update awspodidentity controller to stop reading in v1beta1 versions of MutatingWebhookConfiguration CRs.
joelddiaz
force-pushed
the
v1-mutatingwebhook
branch
from
12908d4
to
7797601
Compare
joelddiaz
changed the title
|
@joelddiaz: This pull request references Bugzilla bug 1954765, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
/assign @dgoodwin |
|
/retest |
|
@dgoodwin PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@joelddiaz: All pull requests linked via external trackers have merged: Bugzilla bug 1954765 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
New kubernetes versions have removed support for v1beta1
MutatingWebhookConfiguration CRs. Migrate to deploying v1.
Update pod-identity-webhook ClusterRole to grant permissions around
certificatesigningrequests (fixes
E0503 15:37:23.227864 1 certificate_manager.go:434] Failed while requesting a signed certificate from the master: cannot create certificate signing request: certificatesigningrequests.certificates.k8s.io is forbidden: User "system:serviceaccount:openshift-cloud-credential-operator:pod-identity-webhook" cannot create resource "certificatesigningrequests" in API group "certificates.k8s.io" at the cluster scope).Add the newly required
admissionReviewVersionsfield to the v1MutatingWebhookConfiguration.
Update awspodidentity controller to stop reading in v1beta1 versions of
MutatingWebhookConfiguration CRs.