Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit test cases for the refresh-keys #403

Merged
merged 2 commits into from
Oct 19, 2021
Merged

unit test cases for the refresh-keys #403

merged 2 commits into from
Oct 19, 2021

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Oct 18, 2021 •
edited
Loading

Unit testcases for the refresh-keys subcommand

@mkumatag
Copy link
Member Author

/assign @joelddiaz @akhil-rane

@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #403 (de7bbfa) into master (ae3a861) will increase coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   46.18%   46.97%   +0.78%     
==========================================
  Files          86       86              
  Lines        8773     8773              
==========================================
+ Hits         4052     4121      +69     
+ Misses       4198     4123      -75     
- Partials      523      529       +6
Impacted Files Coverage Δ
pkg/cmd/provisioning/ibmcloud/refresh-keys.go 38.20% <100.00%> (+38.20%) ⬆️
pkg/cmd/provisioning/ibmcloud/service_id.go 82.98% <0.00%> (+6.63%) ⬆️
pkg/ibmcloud/mock/client_generated.go 82.35% <0.00%> (+18.62%) ⬆️

@mkumatag mkumatag force-pushed the ut-refresh-keys branch 2 times, most recently from bb98b9e to fc1f995 Compare October 19, 2021 05:03
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2021
joelddiaz
joelddiaz reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@akhil-rane don't know if you also want to take a look, otherwise i can just go ahead and lgtm

akhil-rane
akhil-rane reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@akhil-rane akhil-rane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@mkumatag
Copy link
Member Author

@joelddiaz @akhil-rane wondering if we can add all the remaining tags because this is just a ut and doesnt impact any functionality..

@akhil-rane
Copy link
Contributor

akhil-rane commented Oct 19, 2021 •
edited
Loading

@joelddiaz @akhil-rane wondering if we can add all the remaining tags because this is just a ut and doesnt impact any functionality..

Sure!

/label docs-approved
/label qe-approved
/label px-approved

@akhil-rane
Copy link
Contributor

/label docs-approved
/label qe-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 19, 2021
@joelddiaz
Copy link
Contributor

/label docs-approved /label qe-approved /label px-approved

This PR is purely unit test cases for already merged code. No functional impact. Hence why we self-labeled.

@openshift-merge-robot openshift-merge-robot merged commit 6a8d145 into openshift:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelddiaz joelddiaz joelddiaz left review comments

@akhil-rane akhil-rane akhil-rane left review comments

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

Assignees

@joelddiaz joelddiaz

@akhil-rane akhil-rane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkumatag @akhil-rane @joelddiaz @openshift-merge-robot