cleanup CCO from ibm-cloud-managed #443
Conversation
CCO is not used in the ibm-cloud-managed profile. Mark all these previously installed resources as needing to be removed in the ibm-cloud-managed profile, and remove the ibm-cloud-managed annotation so they don't get installed again.
|
/cc @csrwng |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/hold
|
I see this error in the CVO when running this release: |
| @@ -2,7 +2,6 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| include.release.openshift.io/ibm-cloud-managed: "true" | |||
There was a problem hiding this comment.
@joelddiaz if we're not removing cloud cred requests from all repos before 4.10, then it doesn't make sense to exclude the CRD just yet
There was a problem hiding this comment.
Yes, I was thinking we'd block this PR until all the depending PRs merge (which of course means we're looking at this stuff landing for 4.11).
| release.openshift.io/delete: "true" | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Service |
There was a problem hiding this comment.
fixed. also added an additional Service that may have long ago been part of CCO and is presently marked for deletion (named 'controller-manager-service') but cover it under the ibm-cloud-managed list of things to delete in the event that it was ever installed on that profile.
The single Service should have been the one with name 'cco-metrics', but there is also an old Serivce that is no longer used by the name of 'controller-manager-service'. Add an entry for that Service so that it too gets cleaned up.
|
@joelddiaz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CCO is not used in the ibm-cloud-managed profile. Mark all these
previously installed resources as needing to be removed in the
ibm-cloud-managed profile, and remove the ibm-cloud-managed annotation
so they don't get installed again.
xref: https://issues.redhat.com/browse/CCO-177