Bug 2041989: no CredentialsRequests in ibm-cloud-managed #1280
Conversation
|
@joelddiaz do we need to add the deletions? This was never shipped. |
|
@squeed If this PR will make it in before 4.10, then the deletions aren't needed. I can update it to just remove the annotations if we think this PR has a chance for 4.10. |
|
@joelddiaz definietly, this will make it in in the next few days. |
The ibm-cloud-managed profile doesn't use the cloud-credential-operator. The CredentialsRequest CRs should not be installed in that environment. Unmark the existing CredentialsRequests so they are no longer installed in ibm-cloud-managed.
joelddiaz
force-pushed
the
no-cco-ibm-cloud-managed
branch
from
dffaa49
to
ced5d09
Compare
|
@squeed ok, i've remove the list of resources marked for deletion |
|
/approve This is a trivial change, I'll override any nasty CI runs. |
|
@joelddiaz this will need a bz to merge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
joelddiaz
changed the title
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@joelddiaz: This pull request references Bugzilla bug 2041989, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@joelddiaz: This pull request references Bugzilla bug 2041989, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
20 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@joelddiaz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@joelddiaz: All pull requests linked via external trackers have merged: Bugzilla bug 2041989 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…redentials-request
Since fc.2, [1,2] landed dropping some:
include.release.openshift.io/ibm-cloud-managed: "true"
annotations. ibm-cloud-managed clusters do not run an in-cluster
cloud-credential operator, so they are all manual-mode credential
management. And ccoctl, the manual management tool, is currently
oblivious to cluster profiles [3]. So there's no functional impact on
anyone to this change, and we'd like to bump the pinned version to
explicitly allow it, while still detecting any future cred changes in
4.10.
Unfortunately, ci-operator does not seem to have a releases entry type
that would allow us to say:
oldest-supported-credentials-request:
image: registry.ci.openshift.org/ocp/release:4.10.0-0.ci-2022-01-26-071949
or anything similar. The supported release types are [4]:
* integration, which seems to be down in the ImageStream level.
* candidate, which gets us to the nightly stream, but which only
accepts a 'rel' offset, not an explicit release name.
* prerelease, which is looking at 4-stable [5], which does not include
nightlies.
* release [6], which fetches from the official OpenShift Update
Service [7], which does not include nightlies.
So instead of pinning a nightly, I'm just floating the "frozen"
version one nightly behind the version being considered. Once we get
an fc.3 we can pin this back down again.
[1]: openshift/cluster-network-operator#1280
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=2041989
[3]: https://issues.redhat.com/browse/CCO-178
[4]: https://github.com/openshift/ci-tools/blob/87153c5ab0013fe34b7dcf5570920cca9f9454c8/pkg/api/types.go#L218-L278
[5]: https://github.com/openshift/ci-tools/blob/87153c5ab0013fe34b7dcf5570920cca9f9454c8/pkg/release/prerelease/client.go#L19
[6]: https://github.com/openshift/ci-tools/blob/87153c5ab0013fe34b7dcf5570920cca9f9454c8/pkg/api/types.go#L328-L337
[7]: https://github.com/openshift/ci-tools/blob/87153c5ab0013fe34b7dcf5570920cca9f9454c8/pkg/release/official/client.go#L19
The ibm-cloud-managed profile doesn't use the cloud-credential-operator.
The CredentialsRequest CRs should not be installed in that environment.
Unmark the existing CredentialsRequests so they are no longer installed
in ibm-cloud-managed.
Create a list of previously-installed CredentialsRequests so that they
are cleaned up by the CVO only on the ibm-cloud-managed profile.
xref: https://issues.redhat.com/browse/CCO-177