Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset #456

abutcher · 2022-03-21T18:45:12Z

No description provided.

failing on installing yaml-patch binary otherwise

Stop trying to detect whether the creds in kube-system/azure-credentials are good enough for Minting new credentials. We now will only support Manual mode (where the annotator does nothing) and Passthrough mode where we will blindly annotate the Secret as 'passthrough'.

Update the Azure actuator to only support passthrough mode. Attempt to clean up previously created App Registrations / Service Principals, but treat failures to clean up as non-critical. In the event that we fail to clean up, set a new "OrphanedCloudResource" condition to document that we were unable to clean up. When successfully cleaning up, clear out the old AzureStatus fields. Add test cases covering the new OrphanedCloudResources condition.

openshift-ci · 2022-03-21T18:45:26Z

@abutcher: This pull request references Bugzilla bug 2066403, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 2058270 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[4.6] Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

suhanime · 2022-03-21T18:50:32Z

/bugzilla refresh

openshift-ci · 2022-03-21T18:50:36Z

@suhanime: This pull request references Bugzilla bug 2066403, which is invalid:

expected dependent Bugzilla bug 2058270 to target a release in 4.7.0, 4.7.z, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abutcher · 2022-03-21T18:51:41Z

/bugzilla refresh

openshift-ci · 2022-03-21T18:51:44Z

@abutcher: This pull request references Bugzilla bug 2066403, which is invalid:

expected Bugzilla bug 2066403 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abutcher · 2022-03-21T18:52:49Z

/bugzilla refresh

openshift-ci · 2022-03-21T18:53:06Z

@abutcher: This pull request references Bugzilla bug 2066403, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2064428 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2064428 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @shivanthi-amara

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

suhanime · 2022-03-21T20:00:18Z

/test e2e-azure

suhanime

/lgtm

/label backport-risk-assessed

/assign @jianping-shu

suhanime · 2022-03-21T19:08:25Z

go.sum

@@ -71,10 +71,8 @@ github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 h1:d+Bc7a5rLufV
 github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578/go.mod h1:uGdkoq3SwY9Y+13GIhn11/XLaGBb4BfwItxLd5jeuXE=
 github.com/agnivade/levenshtein v1.0.1/go.mod h1:CURSv5d9Uaml+FovSIICkLbAUZ9S4RqaHDIsdSBg7lM=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
-github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 h1:JYp7IbQjafoB+tBA3gMyHYHrpOtNuDiK/uB5uXxq5wM=


Confused why these h1 hashes had to go from a go mod tidy and go mod vendor

openshift-ci · 2022-03-21T20:02:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abutcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-03-21T21:40:39Z

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jianping-shu · 2022-03-22T08:17:21Z

Tested with OCP-47143 (with registry.build01.ci.openshift.org/ci-ln-yg7rdtb/release:latest, 4.6 image based on the PR), passed
Tested with OCP-47144 and OCP-47159 (upgrade from 4.6 version whose default mode is "mint" to registry.build01.ci.openshift.org/ci-ln-yg7rdtb/release:latest, 4.6 image based on the PR), passed

jianping-shu · 2022-03-22T08:17:33Z

/label cherry-pick-approved

openshift-ci · 2022-03-22T08:19:30Z

@abutcher: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#456

Bugzilla bug 2066403 has been moved to the MODIFIED state.

In response to this:

Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akhil-rane added 9 commits March 21, 2022 12:56

update azure-sdk-for-go

ffcf9d2

update github.com/Azure/go-autorest

a5659fe

update build-machinery-go vendor

0aaaa18

failing on installing yaml-patch binary otherwise

Updates to mock files

086083c

vendor updates after removing secret annotation on Azure

ccedbef

update vendoring after removing mint mode support

401992d

update docs for Azure Mint mode removal

c4339a1

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 21, 2022

openshift-ci bot requested review from staebler and twiest March 21, 2022 18:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022

abutcher changed the title ~~[4.6] Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset~~ Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset Mar 21, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 21, 2022

openshift-ci bot requested a review from shivanthi-amara March 21, 2022 18:53

suhanime reviewed Mar 21, 2022

View reviewed changes

openshift-ci bot assigned jianping-shu Mar 21, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 21, 2022

openshift-ci bot assigned suhanime Mar 21, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 22, 2022

openshift-merge-robot merged commit 83a0ef4 into openshift:release-4.6 Mar 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset #456

Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset #456

abutcher commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

suhanime commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

abutcher commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

abutcher commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

suhanime commented Mar 21, 2022

suhanime left a comment

suhanime Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

jianping-shu commented Mar 22, 2022

jianping-shu commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset #456

Bug 2066403: Remove Azure mint mode support as Active Directory Graph API will be sunset #456

Conversation

abutcher commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

suhanime commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

abutcher commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

abutcher commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

suhanime commented Mar 21, 2022

suhanime left a comment

Choose a reason for hiding this comment

suhanime Mar 21, 2022

Choose a reason for hiding this comment

openshift-ci bot commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

jianping-shu commented Mar 22, 2022

jianping-shu commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022