Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2012: ccoctl: Add --enable-tech-preview arg to azure create-all subcommand. #581

Merged

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented Jul 25, 2023

This will enable e2e-azure-manual-oidc to process the CAPI credentials request which is marked TechPreviewNoUpgrade.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@abutcher abutcher changed the title ccoctl: Add --enable-tech-preview arg to azure create-all subcommand. OCPCLOUD-2012: ccoctl: Add --enable-tech-preview arg to azure create-all subcommand. Jul 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2023

@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2023

@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue.

In response to this:

This will enable e2e-azure-manual-oidc to process the CAPI credentials request which is marked TechPreviewNoUpgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member Author

/assign @jstuever

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #581 (5d127dd) into master (b4d1c3d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   48.15%   48.14%   -0.01%     
==========================================
  Files          94       94              
  Lines       11543    11544       +1     
==========================================
  Hits         5558     5558              
- Misses       5377     5378       +1     
  Partials      608      608              
Files Changed Coverage Δ
pkg/cmd/provisioning/azure/create_all.go 0.00% <0.00%> (ø)

@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0e376e4 into openshift:master Jul 26, 2023
9 checks passed
@abutcher abutcher deleted the ccoctl-azure-create-all-tp branch July 26, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants