Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2012: Add azure-manual-oidc workload to cluster-capi-operator #41652

Merged
merged 3 commits into from Aug 23, 2023

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented Jul 25, 2023

Requires openshift/cloud-credential-operator#581 to enable ccoctl azure create-all --enable-tech-preview.

Will enable testing of Azure workload identity credentials generation for openshift/cluster-capi-operator#124.

/hold

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2023

@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue.

In response to this:

Requires openshift/cloud-credential-operator#581 to enable ccoctl azure create-all --enable-tech-preview

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2023
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2023

@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue.

In response to this:

Requires openshift/cloud-credential-operator#581 to enable ccoctl azure create-all --enable-tech-preview.

Will enable testing of Azure workload identity credentials generation for openshift/cluster-capi-operator#124.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 26, 2023
@abutcher abutcher changed the title OCPCLOUD-2012: Add azure-manual-oidc workload to cluster ingress operator OCPCLOUD-2012: Add azure-manual-oidc workload to cluster-api-operator Jul 26, 2023
@abutcher abutcher changed the title OCPCLOUD-2012: Add azure-manual-oidc workload to cluster-api-operator OCPCLOUD-2012: Add azure-manual-oidc workload to cluster-capi-operator Jul 26, 2023
@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@jstuever
Copy link
Contributor

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc

@jstuever
Copy link
Contributor

/pj-rehearse pull-ci-openshift-cluster-api-operator-main-e2e-azure-manual-oidc

@jstuever
Copy link
Contributor

/pj-rehearse auto-ack

@jstuever
Copy link
Contributor

/pj-rehearse abort

@jstuever
Copy link
Contributor

Rehearsals passed on pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc, which tests all of the operators. I don't see a purpose in rehearsing on the individual operator repos. I recommend we apply rehearse-ack.

@abutcher
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 27, 2023
@abutcher
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc

@abutcher
Copy link
Member Author

/hold
for rehearse signal

@abutcher
Copy link
Member Author

Installation succeeded in master job rehearsal but failed on a specific test.

[sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster should report telemetry [Late] [Skipped:Disconnected] [Suite:openshift/conformance/parallel]

@abutcher
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc

@abutcher
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@abutcher
Copy link
Member Author

Rebased.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@abutcher: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn-manual-oidc openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.15-e2e-azure-ovn-manual-oidc openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.14-e2e-azure-ovn-manual-oidc openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-master-e2e-azure-manual-oidc openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.15-e2e-azure-manual-oidc openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.14-e2e-azure-manual-oidc openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-manual-oidc openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.15-e2e-azure-manual-oidc openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.14-e2e-azure-manual-oidc openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-azure-manual-oidc openshift/cluster-cloud-controller-manager-operator presubmit Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-release-4.15-e2e-azure-manual-oidc openshift/cluster-cloud-controller-manager-operator presubmit Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-release-4.14-e2e-azure-manual-oidc openshift/cluster-cloud-controller-manager-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-master-e2e-azure-manual-oidc openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.15-e2e-azure-manual-oidc openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-machine-api-operator-release-4.14-e2e-azure-manual-oidc openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-master-e2e-azure-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.15-e2e-azure-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.14-e2e-azure-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-api-operator-main-e2e-azure-manual-oidc openshift/cluster-api-operator presubmit Presubmit changed
pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.15-e2e-azure-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.14-e2e-azure-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-azure-ipi-workload-identity-tp-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-azure-ipi-workload-identity-tp-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-azure-ipi-workload-identity-tp-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-azure-ipi-workload-identity-tp-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-ec-4.14-azure-ipi-workload-identity-tp-f28 N/A periodic Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.15-periodics-e2e-azure-manual-oidc N/A periodic Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.14-periodics-e2e-azure-manual-oidc N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jstuever
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, damdo, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever
Copy link
Contributor

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc pull-ci-openshift-cluster-api-operator-main-e2e-azure-manual-oidc

@jstuever
Copy link
Contributor

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc
/pj-rehearse pull-ci-openshift-cluster-api-operator-main-e2e-azure-manual-oidc

@openshift-ci-robot
Copy link
Contributor

@jstuever, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase repo client

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@damdo
Copy link
Member

damdo commented Aug 21, 2023

@abutcher looks like it needs another one as some of those files have changed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2023
@damdo
Copy link
Member

damdo commented Aug 23, 2023

@abutcher it looks like this doesn't need rebase anymore, if you are happy with this we should add the rehearsals results you can add the relevant rehearsals-ack label so that this can merge.

@abutcher
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 23, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD aec0a90 and 2 for PR HEAD 9afc220 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ab12787 into openshift:master Aug 23, 2023
22 checks passed
prb112 pushed a commit to prb112/openshift-release that referenced this pull request Sep 12, 2023
openshift#41652)

* OCPCLOUD-2012: Add azure-manual-oidc workload to cluster capi operator

* Base using --enable-tech-preview in AZWI creds provisioning on ENABLE_TECH_PREVIEW_CREDENTIALS_REQUESTS env var having been set.

* Fix ADDITIONAL_CCOCTL_ARGS typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants