New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2012: Add azure-manual-oidc workload to cluster-capi-operator #41652
OCPCLOUD-2012: Add azure-manual-oidc workload to cluster-capi-operator #41652
Conversation
@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/lgtm |
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc |
/pj-rehearse pull-ci-openshift-cluster-api-operator-main-e2e-azure-manual-oidc |
/pj-rehearse auto-ack |
/pj-rehearse abort |
Rehearsals passed on |
/pj-rehearse ack |
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc |
/hold |
Installation succeeded in master job rehearsal but failed on a specific test.
|
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc |
/unhold |
…_TECH_PREVIEW_CREDENTIALS_REQUESTS env var having been set.
23a5661
to
9afc220
Compare
Rebased. |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, damdo, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc pull-ci-openshift-cluster-api-operator-main-e2e-azure-manual-oidc |
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc |
@jstuever,
|
@abutcher looks like it needs another one as some of those files have changed. |
@abutcher it looks like this doesn't need rebase anymore, if you are happy with this we should add the rehearsals results you can add the relevant rehearsals-ack label so that this can merge. |
/pj-rehearse ack |
@abutcher: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift#41652) * OCPCLOUD-2012: Add azure-manual-oidc workload to cluster capi operator * Base using --enable-tech-preview in AZWI creds provisioning on ENABLE_TECH_PREVIEW_CREDENTIALS_REQUESTS env var having been set. * Fix ADDITIONAL_CCOCTL_ARGS typo.
Requires openshift/cloud-credential-operator#581 to enable
ccoctl azure create-all --enable-tech-preview
.Will enable testing of Azure workload identity credentials generation for openshift/cluster-capi-operator#124.
/hold